Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused FCOEmbassyScraper #2403

Merged
merged 2 commits into from Mar 29, 2016
Merged

Commits on Mar 29, 2016

  1. Remove unused FCOEmbassyScraper class

    * This class was added 4 years ago in 2012 [1].
    
    * There are no references to it in the code or the documentation.
    
    * I'm not aware of any developers using it in the last year or so.
    
    * The `www.fco.gov.uk` URL which it scrapes now redirects to a page on
      `www.gov.uk` [2], which I think is the source for the Worldwide API that the
      app is currently using to obtain embassy data anyway.
    
    [1]: 0c19b15
    [2]: https://www.gov.uk/government/world/organisations
    floehopper committed Mar 29, 2016
    Copy the full SHA
    47de917 View commit details
    Browse the repository at this point in the history
  2. Remove unused lib/data/countries.yml

    This file was used by `LegacyCountry` and by `FCOEmbassyScraper`, but these
    have now both been removed and so this file is no longer needed and can be
    removed.
    floehopper committed Mar 29, 2016
    Copy the full SHA
    f39634d View commit details
    Browse the repository at this point in the history