Add 2016/17 rates for register-a-death #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroos
force-pushed
the
add-2016-17-rates-for-register-a-death
branch
2 times, most recently
from
5a845bb
to
6cf7b43
Compare
|
PP LGTM |
To DRY up some of the duplication between north_korea_result and oru_result.
This will allow us to add rates for 2016/17 that can be deployed before 6 April 2016. I wanted to set the start_date as 2015-04-06 but that causes the register-a-death regression tests to fail after I add rates for 2016/17. This is because the date for the regression tests is hardcoded as 1 Jan 2015 which means that no suitable rates are found, which means that the `RatesQuery` falls back to using the most recent rates (2016/17). Setting the start_date to 2015-01-01 ensures that these rates continue to be used in the regression tests.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
register-a-death \
lib/data/rates/register_a_death.yml
This is necessary because of the unrelated changes to
the `RegistrationsDataQuery` class.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
register-a-birth
This is necessary because of the unrelated changes to
the `RegistrationsDataQuery` class.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
marriage-abroad
chrisroos
force-pushed
the
add-2016-17-rates-for-register-a-death
branch
from
6cf7b43
to
7d59573
Compare
|
Thanks for reviewing, @ikennaokpala! I've rebased this on master and force pushed in preparation for merging. I ran the register-a-death regression tests locally to confirm that they're still passing after the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card: https://trello.com/c/SWiqvfDo
I've extracted the hardcoded fees table from north_korea_result and oru_result outcomes templates and moved it to a new _fees partial.
I've extracted the hardcoded costs from the new _fees and moved them to the new register_a_birth.yml rates file.
I've added the 2016/17 rates and checked that they'll be displayed from 6 April 2016 by deploying to Heroku and setting the
RATES_QUERY_DATEenvironment variable to 6 April.Factcheck
Price change for Afghanistan
Expected changes after 6 April 2016
URLs to check
Before 6 April 2016
After 6 April 2016