Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2016/17 rates for register-a-death #2425

Merged
merged 5 commits into from Apr 5, 2016
Merged

Add 2016/17 rates for register-a-death #2425

merged 5 commits into from Apr 5, 2016

Commits on Apr 5, 2016

  1. Extract register-a-death fees partial 

    To DRY up some of the duplication between north_korea_result and
oru_result.
    @chrisroos
    chrisroos committed Apr 5, 2016
    Configuration menu
    Copy the full SHA
    a3ac265 View commit details
    Browse the repository at this point in the history

  2. Move Register a Death fees into rates file 

    This will allow us to add rates for 2016/17 that can be deployed before
6 April 2016.

I wanted to set the start_date as 2015-04-06 but that causes the
register-a-death regression tests to fail after I add rates for 2016/17.
This is because the date for the regression tests is hardcoded as 1 Jan
2015 which means that no suitable rates are found, which means that the
`RatesQuery` falls back to using the most recent rates (2016/17).
Setting the start_date to 2015-01-01 ensures that these rates continue
to be used in the regression tests.
    @chrisroos
    chrisroos committed Apr 5, 2016
    Configuration menu
    Copy the full SHA
    919071b View commit details
    Browse the repository at this point in the history

  3. Update checksum data for register-a-death 

    Updated using:

    $ rails r script/generate-checksums-for-smart-answer.rb \
    register-a-death \
    lib/data/rates/register_a_death.yml
    @chrisroos
    chrisroos committed Apr 5, 2016
    Configuration menu
    Copy the full SHA
    f2acc76 View commit details
    Browse the repository at this point in the history

  4. Update checksum data for register-a-birth 

    This is necessary because of the unrelated changes to
the `RegistrationsDataQuery` class.

Updated using:

    $ rails r script/generate-checksums-for-smart-answer.rb \
    register-a-birth
    @chrisroos
    chrisroos committed Apr 5, 2016
    Configuration menu
    Copy the full SHA
    9872122 View commit details
    Browse the repository at this point in the history

  5. Update checksum data for marriage-abroad 

    This is necessary because of the unrelated changes to
the `RegistrationsDataQuery` class.

Updated using:

    $ rails r script/generate-checksums-for-smart-answer.rb \
    marriage-abroad
    @chrisroos
    chrisroos committed Apr 5, 2016
    Configuration menu
    Copy the full SHA
    7d59573 View commit details
    Browse the repository at this point in the history