Avoid fixtures in WorldwideOrganisation tests #2448
Conversation
I want to be able to update the fixture data (it's also used by the regression tests) without having to update these tests. I've replaced the "finding organisations in a location" test with an alternative that tests the `.for_location` method by stubbing the `GdsApi::Worldwide#organisations_for_world_location` method. The previous implementation used WebMock to stub the real API and relied on the behaviour of `#organisations_for_world_location`.
I want to be able to update the fixture data (it's also used by the regression tests) without having to update these tests.
I want to be able to update the fixture data (it's also used by the regression tests) without having to update these tests.
I want to be able to update the fixture data (it's also used by the regression tests) without having to update these tests.
I want to be able to update the fixture data (it's also used by the regression tests) without having to update these tests.
I want to be able to update the fixture data (it's also used by the regression tests) without having to update these tests.
It's no longer being used.
chrisroos
force-pushed
the
avoid-fixtures-in-worldwide-organisation-tests
branch
from
4dbb076
to
8fe6be3
Compare
| OpenStruct.new(title: 'organisation-1-title'), | ||
| OpenStruct.new(title: 'organisation-2-title') | ||
| ] | ||
| worldwide_api = stub |
There was a problem hiding this comment.
Minor: I might be inclined to give this stub a name. It would make any error messages easier to understand.
There was a problem hiding this comment.
Minor: I might be inclined to give this stub a name. It would make any error messages easier to understand.
Addressed in e4a9921.
|
Minor: I think it might be good to explain why you chose to use instances of |
|
Other than my mostly minor comments, this looks good to me. 👍 |
|
I'm closing this in order to rebase on master and address @floehopper's feedback. |
I've added the following paragraph to each of the commits in PR #2471 that use an OpenStruct in the tests:
|
|
Thanks for the review, @floehopper. I've rebased this branch on master, addressed your comments and opened PR #2471 in preparation for merging to master. |
I've updated the tests for
WorldwideOrganisationto use data setup within the tests rather than data from the organisation fixtures in test/fixtures/worldwide/*.json.I want to update the organisation fixture data to help with some changes I'm making to marriage-abroad. Updating that data at the moment causes a number of these
WorldwideOrganisationtests to fail because the data they're relying on changes. The changes in this branch will allow me to update the organisation fixture data without having to also change these tests.