Split marriage-abroad outcome for Brazil #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As for #2597, I think it would be helpful to explain a little more about your motivation for making this change. |
|
This looks good to me 👍 |
The current outcome for ceremonies in Brazil (outcome_marriage_in_brazil_when_residing_in_brazil_or_third_country) contains two logical outcomes: * One for residents of Brazil * One for residents of a third country (i.e. not resident in the UK or Brazill) The outcome body contains a single `if/else` statement that decides which logical outcome to display. Splitting these logical outcomes and moving the "routing logic" to the flow is more consistent with the majority of this Smart Answer. This change will make it easier to split the outcome in a subsequent commit.
The new template is a duplicate of outcome_marriage_in_brazil_when_residing_in_brazil_or_third_country. I'll remove the resident-of-Brazil logic and content from this new template in a subsequent commit.
I'll remove the resident-of-third-country logic and content from this template in a subsequent commit.
I've removed all the logic and content for residents of a third country. The diff is probably best viewed using the `--ignore-all-space` option.
I've removed all the logic and content for residents of Brazil. The diff is probably best viewed using the `--ignore-all-space` option.
This outcome is only ever shown for residents of a third country.
Updating because the marriage-abroad regression tests are passing.
chrisroos
force-pushed
the
split-marriage-abroad-outcome-for-brazil
branch
from
6c11ff7
to
6aed605
Compare
I've updated the PR description to better explain why I'm making this change. I've also rewritten some of the commit notes to add more information. |
|
I've rebased this on master and force pushed in preparation for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current outcome for ceremonies in Brazil (outcome_marriage_in_brazil_when_residing_in_brazil_or_third_country) contains two logical outcomes:
The outcome body contains a single
if/elsestatement that decides which logical outcome to display. Splitting these logical outcomes and moving the "routing logic" to the flow is more consistent with the majority of this Smart Answer.