Enable JavaScript testing with Poltergeist #230
Conversation
features/whitehall.feature
Outdated
| @@ -132,5 +132,4 @@ Feature: Whitehall | |||
| And I force a varnish cache miss | |||
| And I am benchmarking | |||
| When I visit "/banknote" | |||
| # Redirects are transparently followed, so the end status code is 200 | |||
There was a problem hiding this comment.
This test shouldn't be modified, for "reasons".
There was a problem hiding this comment.
I know, I've sent @davidillsley a Slack (and CC here for good measure)
There was a problem hiding this comment.
I already talked to him a couple of weeks ago. Let's not change it.
There was a problem hiding this comment.
I think I have to change it. For some reason, Poltergeist will successfully redirect pages, but won't update the status code from 301 to 200. As pointed out here, integration tests like this should be using a website how a user would use a website - and that doesn't include looking at status codes. (Arguably better practice still than checking the path is checking for a known element on the page to ensure it's actually been rendered).
Why can't we change it?
|
|
||
| When /^I inject a JavaScript error on the page, Smokey raises an exception$/ do | ||
| expect { page.driver.execute_script('1.error') }.to raise_error | ||
| end |
There was a problem hiding this comment.
No trailing line here (we should add govuk-lint to this repo).
|
|
||
| @normal | ||
| Scenario: Smokey detects JS errors | ||
| When I inject a JavaScript error on the page, Smokey raises an exception |
alecgibson
force-pushed
the
capybara-webkit
branch
2 times, most recently
from
8cc6c02
to
700355c
Compare
alphagov/smokey#230 will make smokey use phantomjs (via poltergeist).
There was a problem hiding this comment.
Cool, almost good to go.
alphagov/govuk-puppet#5427 will have to run on production before we merge this though.
jenkins.sh
Outdated
| bundle install --path "${HOME}/bundles/${JOB_NAME}" --deployment --quiet | ||
| RESTCLIENT_LOG="log/smokey-rest-client.log" govuk_setenv default bundle exec rake $MYTASK | ||
| bundle install --path "${HOME}/bundles/${JOB_NAME}" --deployment | ||
| RESTCLIENT_LOG="log/smokey-rest-client.log" govuk_setenv default xvfb-run -a bundle exec rake $MYTASK |
There was a problem hiding this comment.
xvfb-run -a is no longer necessary. It was added to make the tests run on webkit.
alecgibson
force-pushed
the
capybara-webkit
branch
from
700355c
to
6c30f1c
Compare
|
@tijmenb is this good to go? |
alecgibson
force-pushed
the
capybara-webkit
branch
from
6c30f1c
to
d0cc782
Compare
| @@ -1,24 +1,23 @@ | |||
| Given /^I am testing in an EFG context$/ do | |||
| # Not sure if there is a better way to do this? | |||
| page.driver.browser.agent.add_auth(efg_base_url, ENV['AUTH_USERNAME'], ENV['AUTH_PASSWORD']) | |||
| # TODO: remove me | |||
There was a problem hiding this comment.
Not sure - @tijmenb ?
Revert "Merge pull request #230 from alphagov/capybara-webkit"
This Pull Request enables JavaScript testing in Smokey with the Poltergeist web driver.
It does this in two steps:
The change to Poltergeist has been made in the hopes of improved stability. For example, with Capybara-Webkit the Scenario
Signon cookies are marked as secure and HttpOnlywould fail intermittently. This was reproducible on a Development environment running against the Integration server.The (immediate) cause was that Capybara-Webkit would not populate the
Capybara::Sessionobject correctly (for example, the body, headers and status code of the response would be missing, but the title would be present, and a screenshot could be output displaying the expected page). I could not figure out anything deeper than this cause (which would presumably involve rooting around in Capybara-Webkit itself).In an attempt to improve stability, I have changed the web driver to Poltergeist. Running under the same conditions, I have not been able to reproduce the previously failing intermittent error.
Trello: https://trello.com/c/WIunrfiT/322-investigate-turning-on-javascript-in-smokey