Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Google Analytics AB tracking #236

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Conversation

alecgibson
Copy link
Contributor

@alecgibson alecgibson commented Feb 7, 2017

This test checks that we are correctly sending a page view tracking event to Google Analytics when A/B testing.

Note that this card is dependent upon:

Follow-up from: #231 (the branch it was based on was deleted)

Trello: https://trello.com/c/g9OyC7Pn/310-tell-google-analytics-about-a-b-tests

@tijmenb tijmenb changed the title Add test for Google Analytics AB tracking [Do not merge] Add test for Google Analytics AB tracking Feb 7, 2017
Copy link
Contributor

@tijmenb tijmenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Marked it do not merge. Once static is deployed this can 🚀 .

@tijmenb
Copy link
Contributor

tijmenb commented Feb 13, 2017

alphagov/static#888 has just been deployed.

@tijmenb tijmenb changed the title [Do not merge] Add test for Google Analytics AB tracking Add test for Google Analytics AB tracking Feb 13, 2017
@tijmenb tijmenb merged commit 5a2bc97 into master Feb 13, 2017
@tijmenb tijmenb deleted the ab-test-ga-test branch February 13, 2017 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants