[DO NOT MERGE] Add test for A/B test Google Analytics tracking #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| query = Rack::Utils.parse_query URI(analytics.first.url).query | ||
| expected_query = "Example:#{@ab_cookie_value}" | ||
| assert query['cd40'] == "Example:#{@ab_cookie_value}", |
There was a problem hiding this comment.
Can this assertion use the local variable from line 49?
alecgibson
force-pushed
the
ab-test-ga-test
branch
from
daf642c
to
4916e7d
Compare
| query = Rack::Utils.parse_query URI(analytics.first.url).query | ||
| expected_query = "Example:#{@ab_cookie_value}" | ||
| assert query['cd40'] == expected_query, | ||
| "Expected a query string cd40=#{expected_query} but instead found cd40=#{query['cd40']}" |
There was a problem hiding this comment.
You can get rid of most of this message if you use the RSpec expectation foo.should == bar or the MiniTest assertion assert_equal(foo, bar, "some message"), which give more informative default failure messages.
alecgibson
force-pushed
the
ab-test-ga-test
branch
from
4916e7d
to
ce2fb9f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks that we are correctly sending a page view tracking event to Google Analytics when A/B testing.
Note that this card is dependent upon:
Trello: https://trello.com/c/g9OyC7Pn/310-tell-google-analytics-about-a-b-tests