Merge pull request #1955 from alphagov/test-permanent-banner

Add ability to make global banner permanent
alphagov · Dec 3, 2019 · cd7f07a · cd7f07a
2 parents ce77c63 + 5e8dede
commit cd7f07a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/app/assets/javascripts/modules/global-bar.js b/app/assets/javascripts/modules/global-bar.js
@@ -10,6 +10,7 @@
   Modules.GlobalBar = function() {
     this.start = function($el) {
       var GLOBAL_BAR_SEEN_COOKIE = "global_bar_seen";
+      var always_on = $el.data("global-bar-permanent");
 
       // If the cookie is not set, let's set a basic one
       if (GOVUK.getCookie(GLOBAL_BAR_SEEN_COOKIE) === null || JSON.parse(GOVUK.getCookie(GLOBAL_BAR_SEEN_COOKIE))["count"] === undefined) {
@@ -25,7 +26,9 @@
 
 
       if ($el.is(':visible')) {
-        incrementViewCount(count);
+        if (!always_on) {
+          incrementViewCount(count);
+        }
         track('Viewed');
       }
 

diff --git a/app/views/notifications/_global_bar.html.erb b/app/views/notifications/_global_bar.html.erb
@@ -4,6 +4,11 @@
   title_href = "/register-to-vote"
   link_text = "Register by 26 November to vote in the General Election on 12 December."
   link_href = false
+
+  # Toggles banner being permanently visible
+  # If true, banner is always_visible & does not disappear automatically after 3 pageviews
+  # Regardless of value, banner is always manually dismissable by users
+  always_visible = false
 -%>
 
 <% if show_global_bar %>
@@ -19,7 +24,7 @@
     <!--<![endif]-->
   <% end %>
   <!--[if gt IE 7]><!-->
-  <div id="global-bar" class="global-bar dont-print" data-module="global-bar">
+  <div id="global-bar" class="global-bar dont-print" data-module="global-bar" <%= "data-global-bar-permanent=true" if always_visible %>>
     <div class="global-bar-message-container">
     <p class="global-bar-message">
       <% if title %>