Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analytics slimmer shims #568

Merged
merged 1 commit into from Apr 7, 2015
Merged

Remove analytics slimmer shims #568

merged 1 commit into from Apr 7, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 7, 2015

Now slimmer uses meta tags to convey page metadata and all apps have been updated to the latest slimmer (and deployed), the inline <script> tag and shims for resetting the original _gaq queue can
be removed.

This also removes the last uses of the GOVUK.Analytics namespace.

cc @benilovj

Now slimmer uses meta tags to convey page metadata, the inline
`<script>` tag and shims for resetting the original _gaq queue can
be removed.
@edds
Copy link
Contributor

@edds edds commented Apr 7, 2015

🎉 Good work!

benilovj added a commit that referenced this pull request Apr 7, 2015
@benilovj benilovj merged commit dfc8b7e into master Apr 7, 2015
1 check passed
1 check passed
default "Build #442 succeeded on Jenkins"
Details
@benilovj benilovj deleted the remove-slimmer-shim branch Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants