Add support for displaying a banner across all of GOV.UK #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previous banner (Register to Vote) did not display on /register-to-vote as users did not need to be directed to the page that they were already on. - This commit removes that functionality.
This allows us to deploy the logic without deploying the copy until it’s needed. Override the controller’s view paths to stub the template. This is borrowed from rspec-rails’ `stub_template` method https://github.com/rspec/rspec-rails/blob/e8054a1cd03044f725030fe8315952 cf3799a395/lib/rspec/rails/example/view_example_group.rb#L86-L88
fofr
reviewed
Mar 13, 2017
| count = count + 1; | ||
| GOVUK.setCookie(GLOBAL_BAR_SEEN_COOKIE, count, {days: 84}); | ||
|
|
||
| if (count == 2) { |
There was a problem hiding this comment.
Should we auto-dismiss after 2/1 view rather than 3? Is the banner informative rather than a call to action?
There was a problem hiding this comment.
This can be configured based on the need for the banner. Currently people are happy with 3 as a default
fofr
reviewed
Mar 13, 2017
| @@ -128,6 +128,7 @@ | |||
| init: function() { | |||
| var activeSurvey = userSurveys.getActiveSurvey(userSurveys.defaultSurvey, userSurveys.smallSurveys); | |||
| if (userSurveys.isSurveyToBeDisplayed(activeSurvey)) { | |||
| $('#global-bar').hide(); // Hide global bar if one is showing | |||
There was a problem hiding this comment.
We currently have some fairly aggressive surveys running (ie every 2 pageviews). We should avoiding running these types of survey during a banner.
There was a problem hiding this comment.
Yep, we've checked on that 👍
fofr
approved these changes
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for a partial to be deployed based on
app/views/root/_promo_banner_example.html.erb. This should include theglobal-barjavascript module in order to enable view count tracking. The banner won't display alongside the survey banner or the emergency publishing banner.app/views/root/_promo_banner.html.erbshould remain empty if the banner isn't in use.Example: