-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add cookie banner #227
Conversation
1b984b1
to
6256243
Compare
81d8885
to
a650de3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Jani. Just got a couple of comments, hope they make sense!
I also noticed when running this locally and looking at the Design System frontend docs site that URLs seem to link directly to the first heading on a page, which means the cookie banner is automatically scrolled out of view. I'm not sure where that behaviour comes from, but I wonder what the reason was behind it and if it's something teams could turn off in the config (otherwise it's unlikely anyone will see the banner) ?
it looks like it's driven by https://docs.cloud.service.gov.uk/ imports a markdown file for the first page and that somehow circumvents the JS |
5a1c879
to
8070c4d
Compare
6fe2f5d
to
545d4c3
Compare
There isn't a way we can conditionally include these only when users enable the banner.
Hi @kr8n3r - thanks for working on this! Was it ready for another review or did you need to do more work on it? (I've added @lfdebrux as a reviewer for when it's ready.) @jonathanglassman Are you ok to work with @kr8n3r on the related documentation PR? I'm happy to pre-i or 2i it. |
it does require writing tests for it, but that would mean setting up a new test framework. |
What
Implement a configurable cookie banner based on the GOV.UK Design system cookie banner component
How to test
To do: