Fix failing builds on Travis #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This has the effect of _downgrading_ middleman-autoprefixer to 2.10.0, which uses a more optimistic version specification for autoprefixer-rails [[1]]. Fortunately, we don't lose much by downgrading, the only changes in the patch fix is to improve error handling in the case where execJS complains that an old version of Node.JS is being used; we can probably live without this. [1]: middleman/middleman-autoprefixer@2d2b849 [2]: middleman/middleman-autoprefixer@v2.10.0...v2.10.1
lfdebrux
force-pushed
the
ldeb-force-bump-autoprefixer-rails
branch
5 times, most recently
from
9eb4d25
to
55f4a12
Compare
lfdebrux
changed the title
Travis CI is currently defaulting to using Node.js v8.x.x because the Travis config file does not specify to use Node at all. This commit uses nvm to make sure that the version of Node used for tests is the same as used for development.
Node.js 10.16.0 was released in April 2019, everyone should be using a newer version than that in production, so there is no need to be using it for development or testing. This commit changes the .nvmrc so it no longer specifies a specific minor or patch version of Node.js, just a specific major version. This has the advantages for developers who can keep their local versions of Node up to date without having to edit this file, and for Travis CI which can use a cached version for quicker testing.
lfdebrux
force-pushed
the
ldeb-force-bump-autoprefixer-rails
branch
from
55f4a12
to
2235787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230.
This PR changes the Travis configuration to make sure it is using the same version of JavaScript as developers, and also changes the gemspec of
govuk_tech_docsso that the newest version of autoprefixer-rails is used.Together these changes allow the Travis builds to work correctly. Bumping
autoprefixer-railsis not enough, because otherwise Travis will use Node.js v8.12.0 and autoprefixer will complain that the version of Node is too old.