Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helpful message when background process succeeds #270

Merged
merged 2 commits into from May 6, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 6, 2014

  • Remove a duplicate module declaration which was causing multiple ajax requests to be made
  • Remove elements on batch success

Fixes #70745188

screen shot 2014-05-06 at 11 57 47

Paul Hayes added 2 commits May 6, 2014
* Batch progress is started in application.html.erb, this created a
second module which duplicated requests, and may have caused some of
the weird differences between flash message and modal
Paul Hayes
* Remove message about “continuing”, the progress spinner and the
progress bar when a batch succeeds
* Move logic out of CSS and into JS using js- prefixed classes
jamiecobbett added a commit that referenced this pull request May 6, 2014
Remove helpful message when background process succeeds
@jamiecobbett jamiecobbett merged commit 526902c into master May 6, 2014
1 check passed
1 check passed
default "Build #534 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the remove-message-on-bulk-complete branch May 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.