Improvements to suggested and archive URLs when editing a mapping [60838740] #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fofr
commented
Nov 22, 2013
fofr
commented
- Archive and suggested URLs are secondary fields that rarely need to be filled in, move them behind a disclosure to avoid confusion
- Introduce text that explains the meaning of both URL types, with appropriate link text to disclose the fields
- Use cancel or remove to switch the view back and reset the field
- Default to showing the fields when they are present
- Switch labels for read only fields to a key-value definition list that simulates label styles
- Introduce a mappings helper to create national archive URLs
- When JS is disabled, show all form values and separate the form with visible legends, and hide JS interactions
- There is a known caveat that if the default host is wrong the national archive link may not work and that the fix isn’t clear to the user
- Cleanup some of the base styles to use more of the bootstrap defaults
- Change how we deal with the non-javascript case so we have hooks for JS enabled and disabled
added 9 commits
November 22, 2013 11:10
* Use larger bootstrap defaults
* Make the date human readable * Return a copyable version that can be pasted into a National archive URL
* Refactor the redirect-to-link class for wider use * Add to the style guide
* We can use bootstrap’s mute instead
* Avoid repaints by toggling JS class before CSS has loaded * Use a class for enabled and disabled * Use minified inline JavaScript instead * This also mimics the Modernizr approach
* Separate into sections with comments * Include content toggle classes * Remove body and pre styles that aren’t being used, or are met by bootstrap defaults
* Archive and suggested URLs are secondary fields that rarely need to be filled in, move them behind a disclosure to avoid confusion * Introduce text that explains the meaning of both URL types, with appropriate link text to disclose the fields * Use cancel or remove to switch the view back and reset the field * Default to showing the fields when they are present * Switch labels for read only fields to a key-value definition list that simulates label styles * Introduce a mappings helper to create national archive URLs * When JS is disabled, show all form values and separate the form with visible legends, and hide JS interactions * Behaviour when creating mapping still TBD * There is known caveat that if the default host is wrong the national archive link may not work and that the fix isn’t clear to the user
* We can’t show a national archive link until the mapping path is canonicalised * Hide the TNA link and alternative field
* We are now using bootstrap default font-size and line-height
|
This looks awesome, good work :) |
| @@ -54,6 +54,21 @@ def mapping_edit_tabs(options = {}) | |||
| end | |||
|
|
|||
| ## | |||
| # Generate national archive index URL | |||
| def national_archive_index_url(mapping) | |||
There was a problem hiding this comment.
I wonder if these two methods really belong in the model layer? Two reasons:
- I think it is probably a model concern
- It would be good to eventually share this code with bouncer, and sharing models (via a gem) is probably how we'd do that
added 2 commits
November 25, 2013 10:43
* Replace example_url, national_archive_url and national_archive_index_url
* Use a terser test format
rgarner
added a commit
that referenced
this pull request
Nov 25, 2013
Improvements to suggested and archive URLs when editing a mapping [60838740]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.