Improvements to suggested and archive URLs when editing a mapping [60838740] #83

fofr · 2013-11-22T12:26:16Z

Archive and suggested URLs are secondary fields that rarely need to be filled in, move them behind a disclosure to avoid confusion
Introduce text that explains the meaning of both URL types, with appropriate link text to disclose the fields
Use cancel or remove to switch the view back and reset the field
Default to showing the fields when they are present
Switch labels for read only fields to a key-value definition list that simulates label styles
Introduce a mappings helper to create national archive URLs
When JS is disabled, show all form values and separate the form with visible legends, and hide JS interactions
There is a known caveat that if the default host is wrong the national archive link may not work and that the fix isn’t clear to the user
Cleanup some of the base styles to use more of the bootstrap defaults
Change how we deal with the non-javascript case so we have hooks for JS enabled and disabled

* Use larger bootstrap defaults

* Make the date human readable * Return a copyable version that can be pasted into a National archive URL

* Refactor the redirect-to-link class for wider use * Add to the style guide

* We can use bootstrap’s mute instead

* Avoid repaints by toggling JS class before CSS has loaded * Use a class for enabled and disabled * Use minified inline JavaScript instead * This also mimics the Modernizr approach

* Separate into sections with comments * Include content toggle classes * Remove body and pre styles that aren’t being used, or are met by bootstrap defaults

* Archive and suggested URLs are secondary fields that rarely need to be filled in, move them behind a disclosure to avoid confusion * Introduce text that explains the meaning of both URL types, with appropriate link text to disclose the fields * Use cancel or remove to switch the view back and reset the field * Default to showing the fields when they are present * Switch labels for read only fields to a key-value definition list that simulates label styles * Introduce a mappings helper to create national archive URLs * When JS is disabled, show all form values and separate the form with visible legends, and hide JS interactions * Behaviour when creating mapping still TBD * There is known caveat that if the default host is wrong the national archive link may not work and that the fix isn’t clear to the user

* We can’t show a national archive link until the mapping path is canonicalised * Hide the TNA link and alternative field

* We are now using bootstrap default font-size and line-height

jamiecobbett · 2013-11-22T13:07:50Z

This looks awesome, good work :)

jamiecobbett · 2013-11-22T13:23:50Z

app/helpers/mappings_helper.rb

@@ -54,6 +54,21 @@ def mapping_edit_tabs(options = {})
  end

  ##
+  # Generate national archive index URL
+  def national_archive_index_url(mapping)


I wonder if these two methods really belong in the model layer? Two reasons:

I think it is probably a model concern

It would be good to eventually share this code with bouncer, and sharing models (via a gem) is probably how we'd do that

After a chat with @rgarner and @fofr, he's going to move these methods to the model.

Methods moved.

jamiecobbett · 2013-11-22T13:26:07Z

app/views/mappings/_site.html.erb

@@ -9,5 +9,5 @@
  <dd><%= site.query_params.presence || 'N/A' %></dd>

  <dt><abbr title="The National Archive">TNA</abbr> timestamp</dt>
-  <dd><%= site.tna_timestamp %></dd>
+  <dd><%= site.tna_timestamp.to_formatted_s(:long) %> (<%= site.tna_timestamp.to_formatted_s(:number) %>)</dd>


If tna_timestamp is nil, this will prevent the page from rendering. For this reason, I avoid adding optional fields to (default) factories as you have done, and instead override them when I need them in a test.

Having said that, I'm going to create a ticket to make tna_timestamp NOT NULL and review other fields, so this change is fine, but my thoughts on optional fields in factories stands.

That logic is sound, and I'll follow it from now on. Also, 👍 on raising that new ticket.

rgarner · 2013-11-22T13:55:50Z

app/views/mappings/index.html.erb

@@ -55,8 +55,8 @@
        <td>
          <%= example_url(mapping) %>
          <% if mapping.redirect? %>
-            <span class="redirects-to">redirects to</span><br>
-            <%= link_to mapping.new_url, mapping.new_url, class: 'redirects-to-link' if mapping.new_url.present? %>
+            <i class="muted">redirects to</i><br>


Wow. i is back as 'alternative voice or mood'. i literally had no idea.

* Replace example_url, national_archive_url and national_archive_index_url

* Use a terser test format

Improvements to suggested and archive URLs when editing a mapping [60838740]

Paul Hayes added 9 commits Nov 19, 2013

Remove custom font size and line spacing

805ce55

* Use larger bootstrap defaults

Show a more useful TNA timestamp

53e7320

* Make the date human readable * Return a copyable version that can be pasted into a National archive URL

Create muted-link class

89ceb8e

* Refactor the redirect-to-link class for wider use * Add to the style guide

Refactor out redirects-to class

c7d3948

* We can use bootstrap’s mute instead

Refactor js class toggle

6098f09

* Avoid repaints by toggling JS class before CSS has loaded * Use a class for enabled and disabled * Use minified inline JavaScript instead * This also mimics the Modernizr approach

Cleanup base CSS

ccc9270

* Separate into sections with comments * Include content toggle classes * Remove body and pre styles that aren’t being used, or are met by bootstrap defaults

Change TNA messaging when creating a mapping

85a2fee

* We can’t show a national archive link until the mapping path is canonicalised * Hide the TNA link and alternative field

Delete typography section of style guide

16c1fd0

* We are now using bootstrap default font-size and line-height

jamiecobbett reviewed Nov 22, 2013
View changes

rgarner reviewed Nov 22, 2013
View changes

Paul Hayes added 2 commits Nov 25, 2013

Move mapping url helpers into model

ac3dda9

* Replace example_url, national_archive_url and national_archive_index_url

Compact mapping spec

be35dbb

* Use a terser test format

rgarner added a commit that referenced this pull request Nov 25, 2013

Merge pull request #83 from alphagov/edit-mapping-improvements

d76b806

Improvements to suggested and archive URLs when editing a mapping [60838740]

rgarner merged commit d76b806 into master Nov 25, 2013

rgarner deleted the edit-mapping-improvements branch Nov 25, 2013

alphagov / transition

Improvements to suggested and archive URLs when editing a mapping [60838740] #83

Improvements to suggested and archive URLs when editing a mapping [60838740] #83

fofr commented Nov 22, 2013

jamiecobbett commented Nov 22, 2013

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

alphagov / transition

Improvements to suggested and archive URLs when editing a mapping [60838740] #83

Improvements to suggested and archive URLs when editing a mapping [60838740] #83

Conversation

fofr commented Nov 22, 2013

jamiecobbett commented Nov 22, 2013

This comment has been minimized.

jamiecobbett Nov 22, 2013 Contributor

This comment has been minimized.

jamiecobbett Nov 22, 2013 Contributor

This comment has been minimized.

fofr Nov 25, 2013 Author Contributor

This comment has been minimized.

jamiecobbett Nov 22, 2013 Contributor

This comment has been minimized.

jamiecobbett Nov 22, 2013 Contributor

This comment has been minimized.

fofr Nov 22, 2013 Author Contributor

This comment has been minimized.

rgarner Nov 22, 2013 Contributor

jamiecobbett Nov 22, 2013
Contributor

jamiecobbett Nov 22, 2013
Contributor

fofr Nov 25, 2013
Author Contributor

jamiecobbett Nov 22, 2013
Contributor

jamiecobbett Nov 22, 2013
Contributor

fofr Nov 22, 2013
Author Contributor

rgarner Nov 22, 2013
Contributor