Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve legibility of diff views #78

Merged
merged 3 commits into from Dec 24, 2014
Merged

Improve legibility of diff views #78

merged 3 commits into from Dec 24, 2014

Commits on Dec 23, 2014

  1. Bump admin gem 

    * Fix alignment of environment label
    @fofr
    fofr committed Dec 23, 2014
    Copy the full SHA
    28b0cfa View commit details
    Browse the repository at this point in the history

  2. Improve legibility of diff views 

    New lines were displaying as thin strips. Spaces between lines made
making comparisons more difficult. The +/- signs were hard to read
against grey text.

* Give each line in the diff a minimum height, making new lines display
thicker and maintaining a vertical rhythm
* Remove space between lines, the content naturally provides this
spacing
* Extend red/green highlight to edges of the view
* Use darker red and green colours for the +/- icons

Based on alphagov/publisher#335
    @fofr
    fofr committed Dec 23, 2014
    Copy the full SHA
    ac5b4da View commit details
    Browse the repository at this point in the history

  3. Include diffy gem version

    @fofr
    fofr committed Dec 23, 2014
    Copy the full SHA
    f7241a3 View commit details
    Browse the repository at this point in the history