Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[target=_blank] to external websites vulnerability #2942

Closed
NickColley opened this issue Jan 4, 2017 · 0 comments
Closed

[target=_blank] to external websites vulnerability #2942

NickColley opened this issue Jan 4, 2017 · 0 comments

Comments

@NickColley
Copy link
Contributor

We're using [target=_blank] which has a vulnerability (https://mathiasbynens.github.io/rel-noopener/)

Used in the share links which has been ported and fixed to government-frontend in the following PR alphagov/government-frontend#217
@bilbof bilbof mentioned this issue Feb 25, 2017
Merged
fofr added a commit to alphagov/static that referenced this issue Feb 27, 2017
@fofr
Don't open print links in a new window
573d9db 
* Target _blank has a vulnerability:
https://mathiasbynens.github.io/rel-noopener/ and
alphagov/whitehall#2942
* Links don’t need to be in a new window
@fofr fofr mentioned this issue Feb 27, 2017
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickColley