Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymorphic attachments #870

Merged
merged 7 commits into from
Sep 23, 2013
Merged

Polymorphic attachments #870

merged 7 commits into from
Sep 23, 2013

Commits on Sep 23, 2013

  1. Migrate attachment associations to columns on attachments

    @tekin
    Graham Ashton authored and tekin committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    0e0bfbf View commit details
    Browse the repository at this point in the history

  2. Add pending migration to drop attachment join model tables

    @tekin
    Graham Ashton authored and tekin committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    9c06d12 View commit details
    Browse the repository at this point in the history

  3. Remove old attachment clean-up scripts

    @tekin
    Graham Ashton authored and tekin committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    eeb6d7c View commit details
    Browse the repository at this point in the history

  4. Remove old attachment join models 

    We've replaced all five of the separate join models (e.g. EditionAttachment
and SupportingPageAttachment) with a polymorphic association.
    @tekin
    Graham Ashton authored and tekin committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    7945c41 View commit details
    Browse the repository at this point in the history

  5. DRY up keep/remove/replace attachment handling 

    The code that initiated the behaviour in Admin::AttachmentActionParamHandler
was duplicated across three controllers, making it easy to fail to
update one of them when the behaviour changed. This commit dries it up,
so any controller that includes the module only needs to call it in a
before filter.
    @tekin
    Graham Ashton authored and tekin committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    5351ee1 View commit details
    Browse the repository at this point in the history

  6. Don't use send unnecessarily

    @tekin
    tekin committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    ebe188d View commit details
    Browse the repository at this point in the history

  7. simplify test data creation

    @tekin
    tekin committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    b1b7b68 View commit details
    Browse the repository at this point in the history