Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly bugs in dogears-go and dogears-forward? #15

Closed
all9n opened this issue Jul 23, 2022 · 3 comments
Closed

Possibly bugs in dogears-go and dogears-forward? #15

all9n opened this issue Jul 23, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@all9n
Copy link

all9n commented Jul 23, 2022

First of all, thanks for the package!

I see 2 places that might be bugs. (Disclaimer: relatively new to Emacs and don't understand how bookmarks work.)

  • In dogears-forward, it seems (nth -1000 '(a b c)) returns a, so dogears-index could go negative?
  • In dogears-go, (bookmark-jump place) returns nil after jumping (at least for me) so the or below is kind of pointless.

    dogears.el/dogears.el

    Lines 234 to 236 in c05b69e

    (or (ignore-errors
    (bookmark-jump place))
    (when-let ((buffer (map-elt (cdr place) 'buffer)))
@alphapapa alphapapa self-assigned this Sep 29, 2022
@alphapapa alphapapa added the bug Something isn't working label Sep 29, 2022
@alphapapa
Copy link
Owner

Thanks. I'll fix this when I get a chance.

@gitrj95
Copy link

gitrj95 commented Feb 28, 2023

i put up a pr for the former: #19

@alphapapa
Copy link
Owner

@all9n This should be fixed by the changes in v0.2-pre. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants