-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Fixes Part 3 #32
Conversation
Hey Jay, Thanks very much for fixing these! I set images to be slightly transparent so that they aren't so bright and contrasty, especially on Solarized Dark. I'd kind of like to keep them that way, unless it's very unpopular. I think it gives a unique feel, kind of subdued and relaxing, which goes with the theme. But I don't feel super strong about it, so if people don't like it, we can remove it. What do you think? |
FWIW I'm still not sure what to think about the image change. I'm glad they don't shine as bright as they do without, but at the same time I never really got used to them looking how they do 😆 |
@The-Compiler Haha, yeah, I never knew what anyone else thought about it. Of course, I didn't think very many people were using the stylesheet, anyway. :) What do you think about making them 25% transparent instead of 50% like they are now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the 25% transparency/75% opacity for the avatars is okay with you, feel free to do that and merge. Thanks, Jay!
I'm going to merge this into |
Yes, please do. Thanks. |
Hi, I've gone and made a few more github fixes.
+
and-
colors in code block comments don't have a white background anymoreFixed some messages being dark in PR history
[possibly contoversial] I upgraded my browser and I noticed github profile pictures are a bit dark. Is there a reason for them dimmed? I added a commit that turned that off.
Fix branch popups (might need a bit more work, but this is a lot better than before)
Fix signed commit popups
Let me know if you see any issues! 😄
This should be very easy to merge into
multi-theme
as it's only touching styl files.