Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Fixes Part 3 #32

Merged
merged 8 commits into from
Nov 14, 2017
Merged

Github Fixes Part 3 #32

merged 8 commits into from
Nov 14, 2017

Conversation

jgkamat
Copy link
Collaborator

@jgkamat jgkamat commented Nov 14, 2017

Hi, I've gone and made a few more github fixes.

  • + and - colors in code block comments don't have a white background anymore

  • Fixed some messages being dark in PR history
    2017-11-14-010651_731x86_scrot
    2017-11-14-012032_595x75_scrot

  • [possibly contoversial] I upgraded my browser and I noticed github profile pictures are a bit dark. Is there a reason for them dimmed? I added a commit that turned that off.
    2017-11-14-010714_662x433_scrot

  • Fix branch popups (might need a bit more work, but this is a lot better than before)
    2017-11-14-010732_353x298_scrot

  • Fix signed commit popups
    2017-11-14-011240_382x333_scrot

Let me know if you see any issues! 😄

This should be very easy to merge into multi-theme as it's only touching styl files.

@alphapapa
Copy link
Owner

Hey Jay,

Thanks very much for fixing these!

I set images to be slightly transparent so that they aren't so bright and contrasty, especially on Solarized Dark. I'd kind of like to keep them that way, unless it's very unpopular. I think it gives a unique feel, kind of subdued and relaxing, which goes with the theme. But I don't feel super strong about it, so if people don't like it, we can remove it. What do you think?

@The-Compiler
Copy link
Collaborator

FWIW I'm still not sure what to think about the image change. I'm glad they don't shine as bright as they do without, but at the same time I never really got used to them looking how they do 😆

@alphapapa
Copy link
Owner

@The-Compiler Haha, yeah, I never knew what anyone else thought about it. Of course, I didn't think very many people were using the stylesheet, anyway. :)

What do you think about making them 25% transparent instead of 50% like they are now?

Copy link
Owner

@alphapapa alphapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the 25% transparency/75% opacity for the avatars is okay with you, feel free to do that and merge. Thanks, Jay!

@jgkamat jgkamat merged commit 165f2ef into alphapapa:master Nov 14, 2017
@jgkamat jgkamat deleted the jay/github-fixes-3 branch November 14, 2017 22:30
@jgkamat
Copy link
Collaborator Author

jgkamat commented Nov 14, 2017

I'm going to merge this into multi-theme as well now, thats good with you @alphapapa, right? :)

@alphapapa
Copy link
Owner

Yes, please do. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants