Fix: Add back-to-top button #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct button positioning for fixed and sticky footer Add option to disable button in _config.yml Add button transparency Reduce button size Add personal website to README.md
george-gca
requested changes
May 23, 2024
|
|
|
Yes, but which changes were made to that file in your commit? |
@abhilesh Like what georage said in this code review, could you explain what do you change for this |
abhilesh
commented
May 24, 2024
There was a problem hiding this comment.
The changes suggested for specifying the colour variables for the button didn't work as expected (see attached screenshots)
I elaborated on the changes made to the js file.
The original file committed in the previous PR was already minified (and hence a one-liner). I added the code specified, minified the file and committed to the PR. If needed, I can beautify the file and add it to the PR
No need for this. Thanks for the explanations, and I didn't know about that sass limitation. LGTM. Thanks for your contribution. |
george-gca
approved these changes
May 24, 2024
george-gca
added a commit
to george-gca/multi-language-al-folio
that referenced
this pull request
May 24, 2024
* Updated tikzjax hash * Added support for search (alshedivat#2415) Added support for search within the template as suggested in alshedivat#581. I decided to go with a client side search based on [Ninja keys](https://github.com/ssleptsov/ninja-keys), but using [deepdub's fork](https://github.com/deepdub-ai/ninja-keys) as basis since it supports fuzzy search. Had to do a bunch of changes to their code to make it work without using node to install everything. Also changed to use some colors defined in our side and using both pages' titles and descriptions for search. Also had to increase the template max width to better accomodate the new item in navigation bar. Missing implementations: - [ ] One thing I'd love to do (but currently have no idea how) would be to change the text next to the search button depending on the platform. For example, if the user is accessing the site on a mac they should use ⌘k instead of ctrl k. - [x] Test how this looks like (and how it is supposed to work) on devices with smaller screens - [x] Support for offline mode Some screenshots: --- ## Dark version    --- ## Light version    --------- Signed-off-by: George Araujo <george.gcac@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: Add back-to-top button (alshedivat#2433) Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md` * Moved search data inside search.liquid (alshedivat#2439) Signed-off-by: George Araujo <george.gcac@gmail.com> * Fixed merg bug Signed-off-by: George Araujo <george.gcac@gmail.com> * Translated search strings Signed-off-by: George Araujo <george.gcac@gmail.com> * Fixed spacing in liquid variables Signed-off-by: George Araujo <george.gcac@gmail.com> * Fixed all weird spacing between liquid variables and curly braces Signed-off-by: George Araujo <george.gcac@gmail.com> * Increased site max width Signed-off-by: George Araujo <george.gcac@gmail.com> * Fixed urls not being localized in search Signed-off-by: George Araujo <george.gcac@gmail.com> * Fixed prettier complaints Signed-off-by: George Araujo <george.gcac@gmail.com> --------- Signed-off-by: George Araujo <george.gcac@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Abhilesh Dhawanjewar <2447878+abhilesh@users.noreply.github.com>
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
karapostK
pushed a commit
to karapostK/karapostK.github.io
that referenced
this pull request
Jul 4, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this pull request
Aug 13, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
YifanJiang233
pushed a commit
to YifanJiang233/al-folio
that referenced
this pull request
Aug 27, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2425
PR #2427 adds a back-to-top button, however the button overlaps with the footer when
footer_fixed: falseand has inadequate spacing withfooter_fixed: trueChanges in this PR:
back_to_top: falsein_config.ymlDemo -
Miscellaneous change - Added personal website under
AcademicstoREADME.md