Added support for a newsletter #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, can someone mark this as an enhancement/feature? I don't think I have the ability to tag this PR as anything. |
|
This looks really nice. As for the background of the light version, I believe it is best to set to white for readability, or maybe a light gray as long at it doesn't look like a disabled element. |
|
Okay, this is how it looks like in light mode now: Dormant
Active
|
george-gca
approved these changes
Jun 19, 2024
|
@asboyer I merged your commit, but just now realized that we forgot about adding this to our README. Would you mind sending a new PR with an explanation added to CUSTOMIZE.md? |
Yes, I'll whip that up now. |
asboyer
added a commit
to asboyer/al-folio
that referenced
this pull request
Jun 19, 2024
In reference to alshedivat#2517 and alshedivat#2517 (comment)
george-gca
pushed a commit
that referenced
this pull request
Jun 20, 2024
In reference to #2517 and #2517 (comment)
ngmarchant
pushed a commit
to ngmarchant/ngmarchant.github.io
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to idea: #2097
In reference to request: #923 (comment)
Added support to integrate a loops.so mailing list into the site.
To use, you need to enable
newsletterin_config.yml. You also must specify a loops endpoint (although I think any mailing list endpoint can work), which you can get when you set up a mailing list on loops. More documentation on loops: here.Once that is enabled, the behavior is different depending on how you specified your footer to behave in
_config.yml. Iffooter_fixed: true, then the sign up will appear at the bottom of the about page, as well as at the bottom of blog posts, if you enablerelated_posts.If
footer_fixed: false, then the newsletter signup will be in the footer (on every page), like it is in on my website.I'm not attached to the placement of the signup, and you can choose to include it wherever you want with
{% include scripts/newsletter.liquid %}. Also if you include positional variables into that, you can choose how you center the signup. So{% include scripts/newsletter.liquid left=true %}positions the signup bar to the left.Here are some screenshots below:
Dark version
Light version
I think the input field color should probably change to maybe be light for both themes? What do you think? I think the dark background looks cool, but I don't usually see that done like that on other sites.
Footer fixed
Footer not fixed
To clarify, if footer isn't fixed, the email signup will appear on every page.