Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing a string containing ' (e.g. “Jackson's Lighthouse”) through Cottle’s P('<string>') breaks #49

Closed
alterNERDtive opened this issue Jul 27, 2020 · 0 comments
Assignees
Labels
bug Something isn't working done implemented, but not merged into release yet EliteAttack RatAttack SpanshAttack
Milestone

Comments

@alterNERDtive
Copy link
Owner

I’m currently passing the string directly as a text parameter to .talk. That means I have to enclose the entire string in ". That in turn means I have to quote the Cottle text in '. And that breaks again if the string enclosed in ' contains a ' character.

Fun.

Possible fix: pass as variables, use " for the Cottle thing, and double escape { and }. Not looking forward to that.

@alterNERDtive alterNERDtive added this to the 2.0.2 milestone Jul 27, 2020
@alterNERDtive alterNERDtive self-assigned this Jul 27, 2020
@alterNERDtive alterNERDtive added the done implemented, but not merged into release yet label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done implemented, but not merged into release yet EliteAttack RatAttack SpanshAttack
Projects
None yet
Development

No branches or pull requests

1 participant