Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support multiple units of time for max_time #125

Merged
merged 2 commits into from Oct 11, 2019

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Oct 11, 2019

Resolves #74

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #125 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   93.94%   94.07%   +0.13%     
==========================================
  Files          54       55       +1     
  Lines        1403     1434      +31     
==========================================
+ Hits         1318     1349      +31     
  Misses         85       85
Impacted Files Coverage Δ
evalml/models/auto_base.py 92.45% <100%> (+0.14%) ⬆️
evalml/utils/__init__.py 100% <100%> (ø) ⬆️
evalml/utils/convert_time.py 100% <100%> (ø)
evalml/tests/automl_tests/test_autoclassifier.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc3d36...05656ae. Read the comment docs.

kmax12
kmax12 approved these changes Oct 11, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@christopherbunn christopherbunn merged commit 8b5ac5b into master Oct 11, 2019
@angela97lin
Copy link
Contributor

angela97lin commented Oct 15, 2019

Really minor but I think this will raise the AssertionError when given a string like '20 s' due to the if unit[-1] == 's': unit = unit[:-1] check?

@christopherbunn
Copy link
Contributor Author

christopherbunn commented Oct 15, 2019

@angela97lin Good catch, I'll push an update to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for different units of time for max_time
4 participants