Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 's' units when setting string max_time #132

Merged
merged 4 commits into from Oct 15, 2019

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Oct 15, 2019

Per Angela's comment on PR #125, this allows 's' units to be used for max_time

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #132 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   94.07%   94.08%   +<.01%     
==========================================
  Files          55       55              
  Lines        1434     1436       +2     
==========================================
+ Hits         1349     1351       +2     
  Misses         85       85
Impacted Files Coverage Δ
evalml/tests/automl_tests/test_autoclassifier.py 100% <100%> (ø) ⬆️
evalml/utils/convert_time.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5ac5b...338e166. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

LGTM!

@christopherbunn christopherbunn merged commit e065177 into master Oct 15, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
@dsherry dsherry deleted the max-time-units branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants