Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide LightGBM warnings #1342

Merged
merged 17 commits into from Oct 28, 2020
Merged

Hide LightGBM warnings #1342

merged 17 commits into from Oct 28, 2020

Conversation

bchen1116
Copy link
Contributor

fix #1330

@bchen1116 bchen1116 self-assigned this Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #1342 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
+ Coverage   99.95%   99.95%   +0.01%     
==========================================
  Files         213      213              
  Lines       13795    13814      +19     
==========================================
+ Hits        13788    13807      +19     
  Misses          7        7              
Impacted Files Coverage Δ
...ents/estimators/classifiers/lightgbm_classifier.py 100.00% <100.00%> (ø)
...alml/tests/component_tests/test_lgbm_classifier.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db97d15...0288c34. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review October 26, 2020 16:08
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 Looks great ! I left a couple of questions.

Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 great! Two considerations:

  1. Can we add unit test coverage which expects that there's no warning raised? For reference I think we do this in a few places in our tests, including in the elasticnet classifier tests

  2. Were we seeing this warning in any usage of our lightgbm estimator? Or was it just for specific components? If its the latter, it would be great to have unit test coverage with a set of parameters which previously resulted in a warning.

I also left a comment on the impl

@bchen1116 bchen1116 merged commit 4d872ae into main Oct 28, 2020
2 checks passed
@dsherry dsherry mentioned this pull request Oct 29, 2020
@freddyaboulton freddyaboulton deleted the bc_1330_warnings branch May 13, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightGBM emits warnings for subsample_freq and subsample
3 participants