Fix 'Invalid Value Encountered' error during AutomLSearch #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1346 +/- ##
==========================================
+ Coverage 99.95% 99.95% +0.01%
==========================================
Files 213 213
Lines 13606 13609 +3
==========================================
+ Hits 13599 13602 +3
Misses 7 7
Continue to review full report at Codecov.
|
bchen1116
requested review from
dsherry,
freddyaboulton,
christopherbunn,
eccabay and
jeremyliweishih
and removed request for
dsherry
jeremyliweishih
approved these changes
Oct 26, 2020
| @@ -37,7 +37,10 @@ def validate(self, pipeline_name, cv_scores): | |||
| cv_scores = pd.Series(cv_scores) | |||
|
|
|||
| messages = [] | |||
| high_variance_cv = abs(cv_scores.std() / cv_scores.mean()) > self.threshold | |||
| if cv_scores.mean() == 0 and cv_scores.std() == 0: | |||
There was a problem hiding this comment.
Would this work if we only check if the mean is equal to 0?
There was a problem hiding this comment.
mm yeah I think so. Since these are scores, if the mean is 0, the std is also 0. Thanks for pointing that out!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1343
This is a highVarianceDataCheck error, rather than a LightGBM Error
Old docs here and new docs here
Note: The LightGBM warning messages are being addressed in this pr