Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DockerHub credentials to CI testing environment #1356

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Add DockerHub credentials to CI testing environment #1356

merged 2 commits into from
Oct 28, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Oct 28, 2020 •
edited
Loading

Cloned from alteryx/featuretools#1204

Thanks to @gsheni @tyler3991 🙏 😁

@dsherry dsherry added testing Issues related to testing. task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. labels Oct 28, 2020
@codecov
Copy link

codecov bot commented Oct 28, 2020 •
edited
Loading

Codecov Report

Merging #1356 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1356   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         213      213           
  Lines       13857    13857           
=======================================
  Hits        13850    13850           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83343aa...6d2d8ca. Read the comment docs.

@tyler3991
Copy link
Contributor

This fixes #1260

@tyler3991 tyler3991 added this to the November 2020 milestone Oct 28, 2020
@dsherry dsherry force-pushed the ds_docker_hub branch 2 times, most recently from 7a44055 to 6d2d8ca Compare October 28, 2020 22:21
@dsherry dsherry marked this pull request as ready for review October 28, 2020 22:22
gsheni
gsheni approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

freddyaboulton
freddyaboulton approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@dsherry dsherry merged commit 70389bc into main Oct 28, 2020
@dsherry dsherry deleted the ds_docker_hub branch October 28, 2020 22:41
This was referenced Oct 28, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@kmax12 kmax12 Awaiting requested review from kmax12

@tyler3991 tyler3991 Awaiting requested review from tyler3991

@angela97lin angela97lin Awaiting requested review from angela97lin

@bchen1116 bchen1116 Awaiting requested review from bchen1116

@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih

Assignees
No one assigned
Labels
task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. testing Issues related to testing.
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dsherry @tyler3991 @gsheni @freddyaboulton