Skip to content

Added Changelog #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Oct 25, 2019
Merged

Added Changelog #136

merged 48 commits into from
Oct 25, 2019

Conversation

jeremyliweishih
Copy link
Collaborator

@jeremyliweishih jeremyliweishih commented Oct 16, 2019 •
edited
Loading

  • CirclCI Test
  • Docs on instructions
    Screen Shot 2019-10-25 at 12 13 16 PM

@codecov
Copy link

codecov bot commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          58       58           
  Lines        1516     1516           
=======================================
  Hits         1430     1430           
  Misses         86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41dfed9...8b088c0. Read the comment docs.

jeremyliweishih
jeremyliweishih commented Oct 17, 2019
View reviewed changes
@jeremyliweishih jeremyliweishih changed the title WIP: Added Changelog Added Changelog Oct 17, 2019
angela97lin
angela97lin previously approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

jeff-hernandez
jeff-hernandez previously approved these changes Oct 17, 2019
View reviewed changes
@kmax12 kmax12 removed their request for review October 22, 2019 16:22
rwedge
rwedge reviewed Oct 22, 2019
View reviewed changes
@angela97lin angela97lin self-requested a review October 25, 2019 17:33
angela97lin
angela97lin previously approved these changes Oct 25, 2019
View reviewed changes
@jeremyliweishih jeremyliweishih merged commit 9c995a2 into master Oct 25, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Merged
@dsherry dsherry deleted the changelog branch May 26, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

@angela97lin angela97lin angela97lin left review comments

@jeff-hernandez jeff-hernandez jeff-hernandez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremyliweishih @rwedge @angela97lin @jeff-hernandez