Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Changelog #136

Merged
merged 48 commits into from
Oct 25, 2019
Merged
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
9d0c662
Added changelog and circleci test
jeremyliweishih Oct 16, 2019
57d0079
Fix syntax
jeremyliweishih Oct 16, 2019
2d822cf
Fix syntax
jeremyliweishih Oct 16, 2019
c789117
Add to changelog
jeremyliweishih Oct 16, 2019
46181ef
Add extlinks
jeremyliweishih Oct 16, 2019
021c84d
Fix config
jeremyliweishih Oct 16, 2019
a9af0ee
Remove check for link
jeremyliweishih Oct 16, 2019
f88c3a3
Remove call
jeremyliweishih Oct 16, 2019
6d3afd1
Added changelog test
jeremyliweishih Oct 17, 2019
b3743b8
Added check if changelog updated
jeremyliweishih Oct 17, 2019
597ae60
Switch docker image
jeremyliweishih Oct 17, 2019
73f559d
Remove extlinks
jeremyliweishih Oct 17, 2019
ccb6611
Added pull_request_tempalte with instructions on changelog
jeremyliweishih Oct 17, 2019
f470aae
Only include future releases for now
jeremyliweishih Oct 17, 2019
b3a6802
Typo
jeremyliweishih Oct 17, 2019
b59e438
Add hidden PR # and update instructions and ci test
jeremyliweishih Oct 17, 2019
9bd6b85
Update template and CI
jeremyliweishih Oct 17, 2019
523257f
Update CI syntax
jeremyliweishih Oct 17, 2019
c2f0541
Fix syntax
jeremyliweishih Oct 17, 2019
5da757f
Test
jeremyliweishih Oct 17, 2019
e1f20b6
Fix syntax
jeremyliweishih Oct 17, 2019
7b74231
Fix syntax
jeremyliweishih Oct 17, 2019
c1dbc03
Test
jeremyliweishih Oct 17, 2019
cfdc00c
Fix syntax
jeremyliweishih Oct 17, 2019
530b419
Forgot slash
jeremyliweishih Oct 17, 2019
c687c37
test
jeremyliweishih Oct 17, 2019
43f95a2
Fix link
jeremyliweishih Oct 17, 2019
bd818a9
Test
jeremyliweishih Oct 17, 2019
ab2f626
Test
jeremyliweishih Oct 18, 2019
b4bf9b4
Test
jeremyliweishih Oct 18, 2019
15bc0bc
Final
jeremyliweishih Oct 18, 2019
06fb63e
Testing regex
jeremyliweishih Oct 18, 2019
d6ca3c0
Final testing
jeremyliweishih Oct 18, 2019
68f5f5c
Final changelog check
jeremyliweishih Oct 18, 2019
edabea8
Merge branch 'master' into changelog
jeremyliweishih Oct 18, 2019
69defd4
Merge branch 'master' into changelog
jeremyliweishih Oct 22, 2019
3385a7a
Remove weird characters
jeremyliweishih Oct 23, 2019
7dc1158
Merge branch 'changelog' of https://github.com/FeatureLabs/evalml int…
jeremyliweishih Oct 23, 2019
3dce7dd
Use css to hide
jeremyliweishih Oct 23, 2019
58288ae
Switch images
jeremyliweishih Oct 23, 2019
cdbde8e
Made css specific to evalml
jeremyliweishih Oct 23, 2019
dd64287
Remove unnecessary comments
jeremyliweishih Oct 23, 2019
fb2de15
Add changelog history
jeremyliweishih Oct 25, 2019
96c7d43
Merge branch 'master' of https://github.com/FeatureLabs/evalml into c…
jeremyliweishih Oct 25, 2019
60efe23
typo
jeremyliweishih Oct 25, 2019
756b332
One line
jeremyliweishih Oct 25, 2019
c004017
Add back prefix
jeremyliweishih Oct 25, 2019
8b088c0
Switch to busybox
jeremyliweishih Oct 25, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,16 @@ jobs:
- run: |
source test_python/bin/activate
codecov


# TODO: Needs update after changelog format change
changelog_updated:
working_directory: ~/evalml
docker:
- image: docker:stable-git
jeremyliweishih marked this conversation as resolved.
Show resolved Hide resolved
steps:
- checkout
- run: echo "${CIRCLE_PULL_REQUEST##https://github.com/FeatureLabs/evalml/pull/}"
- run: cat docs/source/changelog.rst | grep ":pr:\`.*<${CIRCLE_PULL_REQUEST##https://github.com/FeatureLabs/evalml/pull/}>\`"
jeremyliweishih marked this conversation as resolved.
Show resolved Hide resolved

workflows:
version: 2
Expand All @@ -84,3 +93,8 @@ workflows:
name: "python 3.7 unit tests"
python_version: "3.7"
codecov: true
- changelog_updated:
name: "changelog updated"
filters:
branches:
ignore: /^master?/
19 changes: 15 additions & 4 deletions docs/source/changelog.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
=========
.. _changelog:
.. TODO: Remove `<` and `>` to unhide

Changelog
=========
---------
**Future Releases**

**v0.0.0**
* Initial Release
* Enhancements
*
* Fixes
*
* Changes
*
* Documentation Changes
* Added Changelog :pr:`‏‏‎<136>`
* Testing Changes
*
14 changes: 11 additions & 3 deletions docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
'sphinx.ext.autosummary',
'sphinx.ext.napoleon',
'sphinx.ext.viewcode',
'sphinx.ext.extlinks',
]

# Add any paths that contain templates here, relative to this directory.
Expand Down Expand Up @@ -189,11 +190,18 @@

# -- Extension configuration -------------------------------------------------

# If evalml is open-sourced: change empty string to '(GH#)' etc.
# and also replace :pr:`‏‏‎<136>` as :pr:`136`
extlinks = {
'issue': ('https://github.com/Featurelabs/evalml/issues/%s', ''),
'pr': ('https://github.com/Featurelabs/evalml/pull/%s', ''),
'user': ('https://github.com/%s', '')
}

autosummary_generate = ["api_reference.rst"]
templates_path = ["_templates"]

html_show_sphinx = False

def setup(app):
app.add_stylesheet("style.css")


html_show_sphinx = False
2 changes: 2 additions & 0 deletions docs/source/index.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,8 @@
},
"source": [
"# Resources\n",
"[Changelog](changelog)\n",
"\n",
"[Roadmap](roadmap)\n",
"\n",
"[API Reference](api_reference)"
Expand Down
5 changes: 5 additions & 0 deletions pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Pull Request Description
(replace this text with your description)

-----
*After creating the pull request: in order to pass the **changelog_updated** check you will need to update the "Future Release" section of* `docs/source/changelog.rst` *to include this pull request by adding :pr:`<123>`.*