Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings from np.array to np.ndarray #1417

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 9, 2020

Closes #1394; np.array refers to the method used to create an array and np.ndarray is the actual data structure.

@angela97lin angela97lin added this to the November 2020 milestone Nov 9, 2020
@angela97lin angela97lin self-assigned this Nov 9, 2020
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #1417 (f1bb6e1) into main (4e2b8fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1417   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         214      214           
  Lines       14133    14133           
=======================================
  Hits        14126    14126           
  Misses          7        7           
Impacted Files Coverage Δ
evalml/data_checks/class_imbalance_data_check.py 100.0% <ø> (ø)
evalml/data_checks/high_variance_cv_data_check.py 100.0% <ø> (ø)
evalml/data_checks/highly_null_data_check.py 100.0% <ø> (ø)
evalml/data_checks/invalid_targets_data_check.py 100.0% <ø> (ø)
evalml/model_understanding/graphs.py 100.0% <ø> (ø)
evalml/objectives/objective_base.py 100.0% <ø> (ø)
evalml/pipelines/binary_classification_pipeline.py 100.0% <ø> (ø)
evalml/pipelines/classification_pipeline.py 100.0% <ø> (ø)
evalml/pipelines/components/component_base.py 100.0% <ø> (ø)
...lines/components/ensemble/stacked_ensemble_base.py 100.0% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e2b8fc...f1bb6e1. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review November 9, 2020 18:59
@angela97lin angela97lin added the documentation Improvements or additions to documentation label Nov 9, 2020
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think you caught them all!

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! 🚢

@angela97lin angela97lin merged commit af6807a into main Nov 10, 2020
@angela97lin angela97lin deleted the 1394_npndarray branch November 10, 2020 16:34
@dsherry dsherry mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation from np.array to np.ndarray
3 participants