New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Woodwork to_pandas
to to_dataframe
and to_series
#1428
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1428 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 216 216
Lines 14228 14226 -2
=========================================
- Hits 14221 14219 -2
Misses 7 7
Continue to review full report at Codecov.
|
to_pandas
to to_dataframe
to_pandas
to to_dataframe
and to_series
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin Looks good to me! Thanks for jumping on this so quickly. Do you know what's up with the coverage change with the ExtensionArray case in _conver_woodwork_types_wrapper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@freddyaboulton Just dug into this. Check this out: Looks like the return type has changed, hence why we no longer need the ExtensionArray. I'll remove it, see if anything breaks. If not, we can just delete those lines for now. |
Good digging @angela97lin ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiice! 🚢
Update Woodwork
to_pandas
toto_dataframe
andto_series
after 0.5.0 release.