Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Woodwork to_pandas to to_dataframe and to_series #1428

Merged
merged 6 commits into from
Nov 12, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 11, 2020

Update Woodwork to_pandas to to_dataframe and to_series after 0.5.0 release.

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #1428 (a018bdb) into main (2998895) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1428     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         216      216             
  Lines       14228    14226      -2     
=========================================
- Hits        14221    14219      -2     
  Misses          7        7             
Impacted Files Coverage Δ
evalml/utils/gen_utils.py 100.0% <ø> (ø)
evalml/automl/automl_search.py 99.7% <100.0%> (ø)
evalml/pipelines/classification_pipeline.py 100.0% <100.0%> (ø)
evalml/pipelines/pipeline_base.py 100.0% <100.0%> (ø)
evalml/pipelines/regression_pipeline.py 100.0% <100.0%> (ø)
evalml/pipelines/utils.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2998895...a018bdb. Read the comment docs.

@angela97lin angela97lin changed the title Update Woodwork to_pandas to to_dataframe Update Woodwork to_pandas to to_dataframe and to_series Nov 11, 2020
@angela97lin angela97lin marked this pull request as ready for review November 11, 2020 22:52
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin Looks good to me! Thanks for jumping on this so quickly. Do you know what's up with the coverage change with the ExtensionArray case in _conver_woodwork_types_wrapper?

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angela97lin
Copy link
Contributor Author

@freddyaboulton Just dug into this. Check this out:

WW 0.0.4:
Screen Shot 2020-11-12 at 11 28 16 AM

WW 0.0.5
Screen Shot 2020-11-12 at 11 29 05 AM

Looks like the return type has changed, hence why we no longer need the ExtensionArray. I'll remove it, see if anything breaks. If not, we can just delete those lines for now.

@freddyaboulton
Copy link
Contributor

Good digging @angela97lin !

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice! 🚢

@angela97lin angela97lin merged commit 87cc77f into main Nov 12, 2020
@angela97lin angela97lin self-assigned this Nov 12, 2020
@angela97lin angela97lin added this to the November 2020 milestone Nov 12, 2020
@angela97lin angela97lin deleted the update_to_pandas_to_to_dataframe branch November 12, 2020 17:44
@dsherry dsherry mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants