Added parameter to InvalidTargetDataCheck to show only top unique values rather than all unique values #1485
Conversation
angela97lin
changed the title
InvalidTargetDataCheck to show only top unique values rather than all unique values
angela97lin
changed the title
InvalidTargetDataCheck to show only top unique values rather than all unique values
Codecov Report
@@ Coverage Diff @@
## main #1485 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 223 223
Lines 15135 15158 +23
=========================================
+ Hits 15128 15151 +23
Misses 7 7
Continue to review full report at Codecov.
|
angela97lin
requested review from
dsherry,
freddyaboulton,
bchen1116,
jeremyliweishih and
ParthivNaresh
| if self.n_unique is None: | ||
| details = {"target_values": unique_values} | ||
| else: | ||
| details = {"target_values": unique_values[:min(self.n_unique, len(unique_values))]} |
There was a problem hiding this comment.
nit-pick: I think the min is redundant because if the end of the slice is larger than the list length, you'll get the whole list anyways.
There was a problem hiding this comment.
Ah, I think if self.n_unique > len(unique_values), you get an IndexError? Though I think I should have written len(unique_values)-1` on second thought.
There was a problem hiding this comment.
I don't think you'd get the index error when you slice a list. But it's a minor point and what you have now works and is clear!
There was a problem hiding this comment.
Woah, TIL slicing is magical and will just give you the whole list, thanks @freddyaboulton :')
(Will likely still keep this/something similar for clarity sake though)
Closes #1460