Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "1535 save graphs to file" #1585

Merged
merged 4 commits into from Dec 18, 2020

Conversation

ParthivNaresh
Copy link
Contributor

Reverts #1550

Reverting due to issues with Kaleido.

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #1585 (bb27eb6) into main (583d60c) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1585     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         240      240             
  Lines       18055    17876    -179     
=========================================
- Hits        18047    17862    -185     
- Misses          8       14      +6     
Impacted Files Coverage Δ
evalml/tests/utils_tests/test_gen_utils.py 100.0% <ø> (ø)
evalml/utils/gen_utils.py 100.0% <ø> (ø)
evalml/tests/conftest.py 98.1% <0.0%> (-1.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583d60c...bb27eb6. Read the comment docs.

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthivNaresh 👍 🚢

@@ -3,7 +3,6 @@ Release Notes

**Future Releases**
* Enhancements
* Added ``save_plot`` that allows for saving of figures from different backends :pr:`1550`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthivNaresh unfortunately our release notes CI check isn't smart enough to know this is a revert 😆

I'd suggest you move this entry to "Fixes", add a second "Revert ..." entry underneath which references PR #1550 and you should be all set. Then when you merge the PR with the fix, you can delete both of those entries

@ParthivNaresh ParthivNaresh merged commit 7a60a91 into main Dec 18, 2020
@dsherry dsherry mentioned this pull request Dec 29, 2020
@freddyaboulton freddyaboulton deleted the revert-1550-1535-save-graphs-to-file branch May 13, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants