-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "1535 save graphs to file" #1585
Conversation
This reverts commit 22cd574.
Codecov Report
@@ Coverage Diff @@
## main #1585 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 240 240
Lines 18055 17876 -179
=========================================
- Hits 18047 17862 -185
- Misses 8 14 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthivNaresh 👍 🚢
@@ -3,7 +3,6 @@ Release Notes | |||
|
|||
**Future Releases** | |||
* Enhancements | |||
* Added ``save_plot`` that allows for saving of figures from different backends :pr:`1550` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthivNaresh unfortunately our release notes CI check isn't smart enough to know this is a revert 😆
I'd suggest you move this entry to "Fixes", add a second "Revert ..." entry underneath which references PR #1550 and you should be all set. Then when you merge the PR with the fix, you can delete both of those entries
Reverts #1550
Reverting due to issues with Kaleido.