-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve describe_pipeline by using pipeline's new describe method #190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 96.78% 96.81% +0.02%
==========================================
Files 91 91
Lines 2333 2353 +20
==========================================
+ Hits 2258 2278 +20
Misses 75 75
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmk if it'd be helpful to discuss live
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minus my few comments, this looks good. one thing is we probably want to rerun some of the notebooks in the docs to update their output
Updated to add number of features (grabbed from estimator) and remove try/except from SimpleImputer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good with the exception of the new warnings that are popping up in the Fraud Prediction Demo
fixes #98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge once tests pass
Still work to be done on this front w/ cross-validation, but grabbing steps from pipeline's describe() rather than automl's clumped parameters for now.
Closes #185, #98