Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve describe_pipeline by using pipeline's new describe method #190

Merged
merged 25 commits into from
Nov 13, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 6, 2019

Still work to be done on this front w/ cross-validation, but grabbing steps from pipeline's describe() rather than automl's clumped parameters for now.

Closes #185, #98

Screen Shot 2019-11-08 at 5 22 46 PM

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #190 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   96.78%   96.81%   +0.02%     
==========================================
  Files          91       91              
  Lines        2333     2353      +20     
==========================================
+ Hits         2258     2278      +20     
  Misses         75       75
Impacted Files Coverage Δ
...components/transformers/imputers/simple_imputer.py 100% <100%> (ø) ⬆️
...l/pipelines/components/transformers/transformer.py 100% <100%> (ø) ⬆️
evalml/model_types/model_types.py 100% <100%> (ø) ⬆️
evalml/utils/logging_utils.py 95.23% <100%> (+0.23%) ⬆️
...lml/tests/pipeline_tests/test_linear_regression.py 100% <100%> (ø) ⬆️
...transformers/feature_selection/feature_selector.py 78.37% <100%> (+4.18%) ⬆️
evalml/models/auto_base.py 93.57% <100%> (-0.2%) ⬇️
evalml/problem_types/problem_types.py 100% <100%> (ø) ⬆️
evalml/pipelines/pipeline_base.py 97.12% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247a546...dffa463. Read the comment docs.

@angela97lin angela97lin self-assigned this Nov 6, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmk if it'd be helpful to discuss live

evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minus my few comments, this looks good. one thing is we probably want to rerun some of the notebooks in the docs to update their output

evalml/model_types/model_types.py Show resolved Hide resolved
evalml/problem_types/problem_types.py Show resolved Hide resolved
docs/source/demos/fraud.ipynb Outdated Show resolved Hide resolved
kmax12
kmax12 previously approved these changes Nov 11, 2019
@angela97lin
Copy link
Contributor Author

Updated to add number of features (grabbed from estimator) and remove try/except from SimpleImputer.

Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good with the exception of the new warnings that are popping up in the Fraud Prediction Demo

docs/Fraud Prediction Demo.ipynb Outdated Show resolved Hide resolved
@kmax12
Copy link
Contributor

kmax12 commented Nov 12, 2019

fixes #98

Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once tests pass

@angela97lin angela97lin merged commit 18ffb63 into master Nov 13, 2019
@angela97lin angela97lin deleted the improve_describe branch November 13, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Describe Pipeline
2 participants