New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "details" to "metadata" for data check actions #2008
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 278 278
Lines 22748 22748
=======================================
Hits 22739 22739
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Is there a similar plan for the warning/error message classes?
@freddyaboulton Currently, no--I think this came up for actions because they're used as data/information elsewhere, whereas for "messages", details seems okay 😅 Open to discussion though, I could see it being a good idea for consistency, and also a good idea to keep as "details" to differentiate? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attention to detail metadata
Closes #1988