Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "details" to "metadata" for data check actions #2008

Merged
merged 12 commits into from
Mar 25, 2021
Merged

Conversation

angela97lin
Copy link
Contributor

Closes #1988

@angela97lin angela97lin self-assigned this Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #2008 (e9dc772) into main (cdb7699) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2008   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         278      278           
  Lines       22748    22748           
=======================================
  Hits        22739    22739           
  Misses          9        9           
Impacted Files Coverage Δ
evalml/data_checks/highly_null_data_check.py 100.0% <ø> (ø)
evalml/data_checks/id_columns_data_check.py 100.0% <ø> (ø)
evalml/data_checks/no_variance_data_check.py 100.0% <ø> (ø)
evalml/data_checks/sparsity_data_check.py 100.0% <ø> (ø)
evalml/data_checks/target_leakage_data_check.py 100.0% <ø> (ø)
evalml/data_checks/uniqueness_data_check.py 100.0% <ø> (ø)
...s/data_checks_tests/test_highly_null_data_check.py 100.0% <ø> (ø)
...ts/data_checks_tests/test_id_columns_data_check.py 100.0% <ø> (ø)
...ests/data_checks_tests/test_sparsity_data_check.py 100.0% <ø> (ø)
...ata_checks_tests/test_target_leakage_data_check.py 100.0% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb7699...e9dc772. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Is there a similar plan for the warning/error message classes?

@angela97lin
Copy link
Contributor Author

@freddyaboulton Currently, no--I think this came up for actions because they're used as data/information elsewhere, whereas for "messages", details seems okay 😅 Open to discussion though, I could see it being a good idea for consistency, and also a good idea to keep as "details" to differentiate? :)

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice refactor

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attention to detail metadata

@angela97lin angela97lin merged commit 0e0ffe9 into main Mar 25, 2021
@angela97lin angela97lin deleted the 1988_metadata branch March 25, 2021 18:56
@chukarsten chukarsten mentioned this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "details" to "metadata" for data check actions
4 participants