Rename "details" to "metadata" for data check actions - #2008
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 278 278
Lines 22748 22748
=======================================
Hits 22739 22739
Misses 9 9
Continue to review full report at Codecov.
|
freddyaboulton
left a comment
There was a problem hiding this comment.
Looks great to me! Is there a similar plan for the warning/error message classes?
|
@freddyaboulton Currently, no--I think this came up for actions because they're used as data/information elsewhere, whereas for "messages", details seems okay 😅 Open to discussion though, I could see it being a good idea for consistency, and also a good idea to keep as "details" to differentiate? :) |
jeremyliweishih
left a comment
There was a problem hiding this comment.
Looks great! Nice refactor
bchen1116
left a comment
There was a problem hiding this comment.
The attention to detail metadata
Closes #1988