Codecov Upload Reports fix #2344
Conversation
| @@ -83,4 +83,5 @@ jobs: | |||
| name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@v1 | |||
| with: | |||
| token: ${{ secrets.CODECOV_TOKEN }} | |||
There was a problem hiding this comment.
So something changed with the codecov/codecov-action@v1 action which now requires this token, whereas previously we didn't have to provide it?
There was a problem hiding this comment.
Correct me if I'm wrong, but the @v1 stuff refers to which version of codecov-action we're checking out, right? I think, if you're interested in previous versions of codecov action, you can change the 1 to a 2 or also specify the specific version of codecov-action you want to try to see whether the latest requires the token or not. Still, very weird that it doesn't correspond to a recent release.
There was a problem hiding this comment.
I'm not so sure that it's an issue with the codecov action, it doesn't seem to have released anything recently. It might be related to how secrets are accessed by GitHub Actions?
Codecov Report
@@ Coverage Diff @@
## main #2344 +/- ##
=====================================
Coverage 99.9% 99.9%
=====================================
Files 281 281
Lines 24607 24607
=====================================
Hits 24578 24578
Misses 29 29 Continue to review full report at Codecov.
|
Fixes issue with Codecov where reports were not being uploaded properly. From now on the CODECOV_TOKEN will be passed to authorize the upload.