Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov Upload Reports fix #2344

Merged
merged 2 commits into from Jun 7, 2021
Merged

Codecov Upload Reports fix #2344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7461289
pass token
ParthivNaresh Jun 7, 2021
64ed615
release notes update
ParthivNaresh Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/linux_unit_tests_with_latest_deps.yml
View file
Open in desktop
Expand Up @@ -83,4 +83,5 @@ jobs:
name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So something changed with the codecov/codecov-action@v1 action which now requires this token, whereas previously we didn't have to provide it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but the @v1 stuff refers to which version of codecov-action we're checking out, right? I think, if you're interested in previous versions of codecov action, you can change the 1 to a 2 or also specify the specific version of codecov-action you want to try to see whether the latest requires the token or not. Still, very weird that it doesn't correspond to a recent release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure that it's an issue with the codecov action, it doesn't seem to have released anything recently. It might be related to how secrets are accessed by GitHub Actions?

fail_ci_if_error: true
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@ Release Notes
* Documentation Changes
* Testing Changes
* Update minimum unit tests to run on all pull requests :pr:`2314`
* Pass token to authorize uploading of codecov reports :pr:`2344`

.. warning::

Expand Down