Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Early Stopping for AutoML #241
Implement Early Stopping for AutoML #241
Changes from 24 commits
8fcdee0
41c5378
f1520f9
4170ea9
06f97ad
49cdb52
ce35c10
131c0e5
ecb7154
3aa4a6d
e00406e
ba3e3bd
5998ad4
1973d66
6c9d3db
3e6663e
6cf3f12
a9411c8
3dcc4dc
cb23096
acff80e
1a11a6c
1dd2ce5
a5bf373
2ab3c0c
64c8b5e
3b6f076
fd5144d
f99b365
e58acd2
be30773
0a44aa1
1aa3a97
0b2a5a5
19f101b
0f100fd
189b14e
2590112
c349781
35c6f6c
ae15446
338600b
9576fd6
173f611
75adca9
10507c9
d638152
95425f2
ed8593d
c1a60a9
173cdea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmax12 what do you think of adding
self._best_id
instead of iterating for the best id/score each time? We could also reuse this forbest_pipeline
. Addingself._best_id
would make getting the best score a constant check vs. a linear run time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd say that a premature optimization. even if there were 1000s of pipelines, a linear search doesn't take much time