-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate DefaultAlgorithm
into AutoMLSearch
#2634
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2634 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 300 301 +1
Lines 27439 27600 +161
=======================================
+ Hits 27395 27556 +161
Misses 44 44
Continue to review full report at Codecov.
|
@@ -235,8 +235,9 @@ def test_multi_objective(X_y_multi): | |||
assert automl.problem_type == ProblemTypes.BINARY | |||
|
|||
|
|||
def test_categorical_classification(X_y_categorical_classification): | |||
def test_categorical_classification(AutoMLTestEnv, X_y_categorical_classification): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By product of testing with EvalMLAlgorithm
. I can remove this but I think these changes are good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work with this, I'm going to take a deeper look at the tests in a bit, just left some other comments. Also do we have plans to update our docs? We briefly mention the standalone search
method in the AutoML section but it might be helpful to have a separate section describing our algorithms. It could be a lot of updates so feel free to file a separate issue for this if you don't want to lump it all into one PR.
@ParthivNaresh, I'll make an issue to track this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeremy, great work. This looks good to me. I think we should figure out (not necessarily in this PR) a new name instead of EvalMLAlgorithm, and same for the resulting string. But yea, would like to see this puppy in action and see how it compares to iterative.
evalml/automl/automl_search.py
Outdated
@@ -254,6 +357,8 @@ class AutoMLSearch: | |||
_pipelines_per_batch (int): The number of pipelines to train for every batch after the first one. | |||
The first batch will train a baseline pipline + one of each pipeline family allowed in the search. | |||
|
|||
_automl_algorithm (str): The automl algorithm to use. Currently the two choices are 'iterative' and 'evalml'. Defaults to `iterative`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to come up with a better alternative to "evalml", haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look great, nice work with this!
EvalMLAlgorithm
into AutoMLSearch
DefaultAlgorithm
into AutoMLSearch
Fixes #2526.
algorithm
parameter to AutoMLSearch