Skip to content

Data exploration on Data Check Actions - #2696

Merged
bchen1116 merged 16 commits into
mainfrom
bc_2500_data
Sep 2, 2021
Merged

Data exploration on Data Check Actions#2696
bchen1116 merged 16 commits into
mainfrom
bc_2500_data

Conversation

@bchen1116

@bchen1116 bchen1116 commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

fix #2500

Docs are here. We put the doc path under User Guide/Data Actions

@bchen1116 bchen1116 self-assigned this Aug 25, 2021
@codecov

codecov Bot commented Aug 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2696 (0bc2152) into main (9352922) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2696   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        301     301           
  Lines      27786   27786           
=====================================
  Hits       27737   27737           
  Misses        49      49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9352922...0bc2152. Read the comment docs.

@bchen1116
bchen1116 marked this pull request as ready for review August 26, 2021 19:12
@bchen1116
bchen1116 requested a review from a team August 26, 2021 19:13

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great @bchen1116! I have a bunch of nits that you can feel free to address or ignore but the links and lists need to be fixed before this can be merged.

Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated

@angela97lin angela97lin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work 👏 !!

Just left a bunch of comments that are mostly nit-picky and grammatical in nature 😂

Comment thread docs/source/user_guide.ipynb Outdated
Comment thread docs/source/user_guide.ipynb
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated
Comment thread docs/source/user_guide/data_actions.ipynb Outdated

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm!

@bchen1116
bchen1116 merged commit 6a1baa9 into main Sep 2, 2021
@chukarsten chukarsten mentioned this pull request Sep 10, 2021
@freddyaboulton
freddyaboulton deleted the bc_2500_data branch May 13, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tutorial for Data Exploration using DataChecks/Actions

3 participants