Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data exploration on Data Check Actions #2696

Merged
merged 16 commits into from Sep 2, 2021
Merged

Data exploration on Data Check Actions #2696

merged 16 commits into from Sep 2, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Aug 25, 2021

fix #2500

Docs are here. We put the doc path under User Guide/Data Actions

@bchen1116 bchen1116 self-assigned this Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #2696 (0bc2152) into main (9352922) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2696   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        301     301           
  Lines      27786   27786           
=====================================
  Hits       27737   27737           
  Misses        49      49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9352922...0bc2152. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review August 26, 2021 19:12
@bchen1116 bchen1116 requested a review from a team August 26, 2021 19:13
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great @bchen1116! I have a bunch of nits that you can feel free to address or ignore but the links and lists need to be fixed before this can be merged.

docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work 👏 !!

Just left a bunch of comments that are mostly nit-picky and grammatical in nature 😂

docs/source/user_guide.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide.ipynb Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/data_actions.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm!

@bchen1116 bchen1116 merged commit 6a1baa9 into main Sep 2, 2021
@chukarsten chukarsten mentioned this pull request Sep 10, 2021
@freddyaboulton freddyaboulton deleted the bc_2500_data branch May 13, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial for Data Exploration using DataChecks/Actions
3 participants