Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imblearn from Oversampler attribute #2755

Merged
merged 2 commits into from Sep 8, 2021
Merged

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Sep 8, 2021

Closes #2754

@eccabay eccabay self-assigned this Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #2755 (fdd390b) into main (e3ec96f) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2755     +/-   ##
=======================================
+ Coverage   99.9%   99.9%   +0.1%     
=======================================
  Files        301     301             
  Lines      27840   27851     +11     
=======================================
+ Hits       27791   27802     +11     
  Misses        49      49             
Impacted Files Coverage Δ
...es/components/transformers/samplers/oversampler.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_oversampler.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ec96f...fdd390b. Read the comment docs.

@eccabay eccabay marked this pull request as ready for review September 8, 2021 19:47
Copy link
Contributor

@christopherbunn christopherbunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting this in so quickly.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch!

@eccabay eccabay merged commit 4dffcfa into main Sep 8, 2021
@eccabay eccabay deleted the 2574_imblearn_oversampler branch September 8, 2021 20:17
@chukarsten chukarsten restored the 2574_imblearn_oversampler branch September 10, 2021 18:46
This was referenced Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove imblearn module from being an attribute of Oversampler
3 participants