Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Woodwork public get_subset_schema instead of private method #3325

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

angela97lin
Copy link
Contributor

Use Woodwork public get_subset_schema instead of private method, closes #3168

@angela97lin angela97lin self-assigned this Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #3325 (afc1b76) into main (562d202) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3325   +/-   ##
=====================================
  Coverage   99.8%   99.8%           
=====================================
  Files        324     324           
  Lines      31764   31764           
=====================================
  Hits       31674   31674           
  Misses        90      90           
Impacted Files Coverage Δ
...transformers/feature_selection/feature_selector.py 100.0% <100.0%> (ø)
...onents/transformers/imputers/per_column_imputer.py 100.0% <100.0%> (ø)
...components/transformers/imputers/simple_imputer.py 100.0% <100.0%> (ø)
...ponents/transformers/preprocessing/featuretools.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562d202...afc1b76. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review February 14, 2022 17:02
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angela97lin angela97lin merged commit 30530c3 into main Feb 14, 2022
@angela97lin angela97lin deleted the 3168_use_get_subset_schema branch February 14, 2022 18:14
@chukarsten chukarsten mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use woodwork public method for _get_subset_schema
2 participants