-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to ensure positive_label
passed properly in AMLSearch
#3326
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3326 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 336 336
Lines 33282 33295 +13
=======================================
+ Hits 33150 33163 +13
Misses 132 132
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
… bc_search_parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just going to block this for a minute for clarity - this has the search_parameters changes in it, yes? Should it be a PR to your search_parameters PR? I don't think we should risk this getting merged before the other PR
"parameter c": 0, | ||
"parameter d": 0, | ||
"parameter e": "option a", | ||
"parameter f": "option a 💩", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I be seeing a poop emoji here???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was work done previously, I didn't change the resutls heh
@jeremyliweishih I rerequested your review now that the actual diff is readable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question about release cleanup and testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you, as always, Bryan.
fix #3068
The main thing we have to make sure is to pass the
label encoder
parameter to the stacked ensembler, since if the problem is classification, it will need these params. Most of this PR adds the logic to pass this param forward. We don't need to pass other parameters forward since we expect the pipelines to already be initialized with their respective parameters.