Repository navigation
Add test to ensure positive_label passed properly in AMLSearch - #3326
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3326 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 336 336
Lines 33282 33295 +13
=======================================
+ Hits 33150 33163 +13
Misses 132 132
Continue to review full report at Codecov.
|
jeremyliweishih
left a comment
There was a problem hiding this comment.
LGTM, great work!
… bc_search_parameters
chukarsten
left a comment
There was a problem hiding this comment.
Just going to block this for a minute for clarity - this has the search_parameters changes in it, yes? Should it be a PR to your search_parameters PR? I don't think we should risk this getting merged before the other PR
| "parameter c": 0, | ||
| "parameter d": 0, | ||
| "parameter e": "option a", | ||
| "parameter f": "option a 💩", |
There was a problem hiding this comment.
should I be seeing a poop emoji here???
There was a problem hiding this comment.
This was work done previously, I didn't change the resutls heh
|
@jeremyliweishih I rerequested your review now that the actual diff is readable |
jeremyliweishih
left a comment
There was a problem hiding this comment.
LGTM, just a question about release cleanup and testing.
chukarsten
left a comment
There was a problem hiding this comment.
Awesome! Thank you, as always, Bryan.
fix #3068
The main thing we have to make sure is to pass the
label encoderparameter to the stacked ensembler, since if the problem is classification, it will need these params. Most of this PR adds the logic to pass this param forward. We don't need to pass other parameters forward since we expect the pipelines to already be initialized with their respective parameters.