Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update leaderboard names to show ranking_score instead of validation_score #3878

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Dec 8, 2022

Change validation_score to ranking_score. This PR will also show the holdout_score if there is a holdout set in the leaderboard.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3878 (25800bb) into main (9f08237) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3878     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        346     346             
  Lines      36325   36352     +27     
=======================================
+ Hits       36188   36221     +33     
+ Misses       137     131      -6     
Impacted Files Coverage Δ
...ts/automl_tests/parallel_tests/test_automl_dask.py 96.1% <ø> (ø)
evalml/automl/automl_search.py 99.6% <100.0%> (+0.2%) ⬆️
evalml/automl/pipeline_search_plots.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 99.5% <100.0%> (+0.1%) ⬆️
...ts/automl_tests/test_automl_iterative_algorithm.py 100.0% <100.0%> (ø)
...l/tests/automl_tests/test_pipeline_search_plots.py 100.0% <100.0%> (ø)
.../integration_tests/test_time_series_integration.py 100.0% <100.0%> (ø)
evalml/automl/engine/engine_base.py 100.0% <0.0%> (+3.4%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christopherbunn christopherbunn force-pushed the OSSEVALML-351_update_leaderboard branch 3 times, most recently from 6298833 to 8fa5c5b Compare December 13, 2022 14:32
@christopherbunn christopherbunn marked this pull request as ready for review December 13, 2022 15:49
Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@christopherbunn christopherbunn merged commit 1ab688d into main Dec 14, 2022
@christopherbunn christopherbunn deleted the OSSEVALML-351_update_leaderboard branch December 14, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants