Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pull request check for linked issues to CI workflow #3970

Merged
merged 18 commits into from
Feb 3, 2023
Merged

Add pull request check for linked issues to CI workflow #3970

merged 18 commits into from
Feb 3, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Feb 1, 2023 •
edited
Loading

@gsheni gsheni changed the title Update lint_tests.yaml Add pull request check for linked issues to CI workflow Feb 1, 2023
@gsheni gsheni self-assigned this Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023 •
edited
Loading

Codecov Report

Merging #3970 (eb5748f) into main (a093df2) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3970   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        347     347           
  Lines      36896   36896           
=====================================
  Hits       36775   36775           
  Misses       121     121

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni marked this pull request as ready for review February 1, 2023 23:11
jeremyliweishih
jeremyliweishih approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@gsheni
Copy link
Contributor Author

gsheni commented Feb 2, 2023

The fix for Build conda package can be found here: #3978

@gsheni gsheni enabled auto-merge (squash) February 3, 2023 16:23
@gsheni gsheni merged commit 9084751 into main Feb 3, 2023
@gsheni gsheni deleted the add_pull_request_check branch February 3, 2023 16:28
@christopherbunn christopherbunn mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@chukarsten chukarsten Awaiting requested review from chukarsten

@fjlanasa fjlanasa Awaiting requested review from fjlanasa

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GitHub actions to check if pull request has linked GitHub issue
3 participants
@gsheni @thehomebrewnerd @jeremyliweishih