Skip to content

Add pull request check for linked issues to CI workflow#3970

Merged
gsheni merged 18 commits into
mainfrom
add_pull_request_check
Feb 3, 2023
Merged

Add pull request check for linked issues to CI workflow#3970
gsheni merged 18 commits into
mainfrom
add_pull_request_check

Conversation

@gsheni

@gsheni gsheni commented Feb 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@gsheni gsheni changed the title Update lint_tests.yaml Add pull request check for linked issues to CI workflow Feb 1, 2023
@gsheni gsheni self-assigned this Feb 1, 2023
@codecov

codecov Bot commented Feb 1, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3970 (eb5748f) into main (a093df2) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3970   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        347     347           
  Lines      36896   36896           
=====================================
  Hits       36775   36775           
  Misses       121     121

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni marked this pull request as ready for review February 1, 2023 23:11
gsheni
gsheni commented Feb 2, 2023
View reviewed changes
Comment thread .github/workflows/pull_request_check.yaml Outdated
jeremyliweishih
jeremyliweishih approved these changes Feb 2, 2023
View reviewed changes

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@gsheni

gsheni commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

The fix for Build conda package can be found here: #3978

@gsheni gsheni enabled auto-merge (squash) February 3, 2023 16:23
@gsheni gsheni merged commit 9084751 into main Feb 3, 2023
@gsheni gsheni deleted the add_pull_request_check branch February 3, 2023 16:28
@christopherbunn christopherbunn mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes
@chukarsten chukarsten Awaiting requested review from chukarsten
@fjlanasa fjlanasa Awaiting requested review from fjlanasa
+1 more reviewer
@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add GitHub actions to check if pull request has linked GitHub issue

3 participants

@gsheni @thehomebrewnerd @jeremyliweishih