Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirements-parser requirement #3978

Merged
merged 9 commits into from
Feb 3, 2023
Merged

Remove requirements-parser requirement #3978

merged 9 commits into from
Feb 3, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Feb 2, 2023 •
edited
Loading

@gsheni gsheni changed the title Remove requirements parser requirement Remove requirements-parser requirement Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023 •
edited
Loading

Codecov Report

Merging #3978 (55cb885) into main (d12659d) will decrease coverage by 0.0%.
The diff coverage is 93.8%.

@@           Coverage Diff           @@
##            main   #3978     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        347     347             
  Lines      36892   36896      +4     
=======================================
+ Hits       36772   36775      +3     
- Misses       120     121      +1
Impacted Files Coverage Δ
...components/transformers/encoders/target_encoder.py 100.0% <ø> (ø)
evalml/utils/cli_utils.py 95.9% <90.0%> (-1.3%) ⬇️
evalml/tests/utils_tests/test_cli_utils.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni self-assigned this Feb 2, 2023
@gsheni gsheni marked this pull request as ready for review February 2, 2023 22:15
@gsheni gsheni requested review from a team and removed request for jeremyliweishih February 2, 2023 22:42
@gsheni gsheni mentioned this pull request Feb 2, 2023
Merged
thehomebrewnerd
thehomebrewnerd reviewed Feb 3, 2023
View reviewed changes
evalml/utils/cli_utils.py
all_specs = ",".join(["".join(spec) for spec in package.specs])
name = package.name
if convert_to_conda and name in CONDA_TO_PIP_NAME:
name = CONDA_TO_PIP_NAME.get(package.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not a big deal, but should we add a test (or parameterize the existing test if we can) to hit this line?

jeremyliweishih
jeremyliweishih approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than adding the missing coverage

@gsheni gsheni merged commit a093df2 into main Feb 3, 2023
@gsheni gsheni deleted the fix_cli_reqs branch February 3, 2023 15:51
@christopherbunn christopherbunn mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd left review comments

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove requirements parser requirement
3 participants
@gsheni @thehomebrewnerd @jeremyliweishih