Repository navigation
Remove requirements-parser requirement - #3978
Merged
Merged
Conversation
gsheni
changed the title
added 2 commits
February 2, 2023 17:03
Codecov Report
@@ Coverage Diff @@
## main #3978 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 347 347
Lines 36892 36896 +4
=======================================
+ Hits 36772 36775 +3
- Misses 120 121 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 2 commits
February 2, 2023 17:12
| all_specs = ",".join(["".join(spec) for spec in package.specs]) | ||
| name = package.name | ||
| if convert_to_conda and name in CONDA_TO_PIP_NAME: | ||
| name = CONDA_TO_PIP_NAME.get(package.name) |
Contributor
There was a problem hiding this comment.
Maybe not a big deal, but should we add a test (or parameterize the existing test if we can) to hit this line?
jeremyliweishih
approved these changes
Feb 3, 2023
jeremyliweishih
left a comment
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
LGTM other than adding the missing coverage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.