Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Remove existing nullable type handlings across automl #4055

Closed

Conversation

tamargrey
Copy link
Contributor

Pull Request Description

(replace this text with your description)


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@tamargrey tamargrey changed the title [DO NOT MERGE] Remove nullable type handlings [DO NOT MERGE] Remove existing nullable type handlings across automl Mar 8, 2023
@machineFL
Copy link
Collaborator

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@tamargrey tamargrey changed the base branch from main to use-nullable-type-handling March 8, 2023 14:29
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #4055 (274f114) into use-nullable-type-handling (6a10435) will decrease coverage by 39.8%.
The diff coverage is 52.9%.

@@                      Coverage Diff                      @@
##           use-nullable-type-handling   #4055      +/-   ##
=============================================================
- Coverage                        99.7%   59.9%   -39.8%     
=============================================================
  Files                             349     350       +1     
  Lines                           37579   37595      +16     
=============================================================
- Hits                            37461   22495   -14966     
- Misses                            118   15100   +14982     
Impacted Files Coverage Δ
...omponents/estimators/regressors/arima_regressor.py 79.9% <ø> (-20.1%) ⬇️
...onents/estimators/regressors/catboost_regressor.py 97.8% <ø> (-2.2%) ⬇️
...tors/regressors/exponential_smoothing_regressor.py 78.5% <ø> (-21.5%) ⬇️
...nents/transformers/imputers/time_series_imputer.py 80.6% <ø> (-19.4%) ⬇️
...es/components/transformers/samplers/oversampler.py 95.9% <ø> (-4.1%) ⬇️
evalml/pipelines/utils.py 84.1% <ø> (-15.5%) ⬇️
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <ø> (ø)
...alml/tests/component_tests/test_arima_regressor.py 0.0% <0.0%> (-100.0%) ⬇️
...nent_tests/test_exponential_smoothing_regressor.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/component_tests/test_imputer.py 0.0% <0.0%> (-100.0%) ⬇️
... and 17 more

... and 186 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamargrey tamargrey force-pushed the temp-update-automl branch 3 times, most recently from 02324fb to dc1f4ab Compare March 9, 2023 15:44
@tamargrey tamargrey force-pushed the use-nullable-type-handling branch 2 times, most recently from 87aec62 to 3c2a968 Compare March 15, 2023 13:13
@tamargrey tamargrey force-pushed the temp-update-automl branch 3 times, most recently from 70b545d to 314f8c5 Compare March 16, 2023 15:26
Base automatically changed from use-nullable-type-handling to component-specific-nullable-types-handling March 17, 2023 20:21
@tamargrey
Copy link
Contributor Author

closing in favor of #4085

@tamargrey tamargrey closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants