Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Remove existing nullable type handlings across automl #4055

Closed
wants to merge 65 commits into from
Closed

[DO NOT MERGE] Remove existing nullable type handlings across automl #4055

wants to merge 65 commits into from

Commits on Mar 17, 2023

  1. Remove existing nullable type handling from oversampler and use _hand… 

    …le_nullable_types instead
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e3ed36a View commit details
    Browse the repository at this point in the history

  2. Add handle call for lgbm regressor and remove existing handling

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    c4f37db View commit details
    Browse the repository at this point in the history

  3. Add handle call for lgbm classifier

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    a064c0a View commit details
    Browse the repository at this point in the history

  4. temp broken exp smoothing tests

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    cace169 View commit details
    Browse the repository at this point in the history

  5. lint fix

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    74ad65f View commit details
    Browse the repository at this point in the history

  6. add release note

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    57ae46e View commit details
    Browse the repository at this point in the history

  7. Fix broken tests by initting woodwork on y in lgbm classifier

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    45eeb07 View commit details
    Browse the repository at this point in the history

  8. Update tests

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    84ef04e View commit details
    Browse the repository at this point in the history

  9. Call handle in arima

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    9d281c0 View commit details
    Browse the repository at this point in the history

  10. call handle from ts imputer y ltype is downcasted value

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    8ac5dd7 View commit details
    Browse the repository at this point in the history

  11. remove unnecessary comments

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    ab688ef View commit details
    Browse the repository at this point in the history

  12. Fix time series guide

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    800008d View commit details
    Browse the repository at this point in the history

  13. lint fix

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    56b2028 View commit details
    Browse the repository at this point in the history

  14. Only call handle_nullable_types when necessary in methods

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    48d61ea View commit details
    Browse the repository at this point in the history

  15. Remove remaining unnecessary handle calls

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    9d1bb0d View commit details
    Browse the repository at this point in the history

  16. resolve remaining comments

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    14b6eae View commit details
    Browse the repository at this point in the history

  17. Add y ww init to ts imputer back in to fix tests

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    3376070 View commit details
    Browse the repository at this point in the history

  18. Copy X in testing nullable types to stop hiding potential incompatibi… 

    …lities in methods
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    1aa92ac View commit details
    Browse the repository at this point in the history

  19. use X_d in lgbm predict proba

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    43939eb View commit details
    Browse the repository at this point in the history

  20. remove nullable type handling after sklearn upgrade fixed incompatibi… 

    …lities
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    4c1d8b8 View commit details
    Browse the repository at this point in the history

  21. use common util to determine type for time series imputed integers

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    f3965fb View commit details
    Browse the repository at this point in the history

  22. Add comments around why we copy X

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    3ef452e View commit details
    Browse the repository at this point in the history

  23. remove _prepare_data from samplers

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    739e2e0 View commit details
    Browse the repository at this point in the history

  24. PR comments

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    2c5c8ce View commit details
    Browse the repository at this point in the history

  25. remove tests to check if handle method is called

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    d22c0a6 View commit details
    Browse the repository at this point in the history

  26. remove nullable types from imputed data because of regularizer

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e5730b6 View commit details
    Browse the repository at this point in the history

  27. fix typo

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    70121d5 View commit details
    Browse the repository at this point in the history

  28. fix docstrings

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    66ccec4 View commit details
    Browse the repository at this point in the history

  29. fix codecov issues

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e85a440 View commit details
    Browse the repository at this point in the history

  30. PR comments

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    a52db7c View commit details
    Browse the repository at this point in the history

  31. Revert "Fix time series guide" 

    This reverts commit 964622a.
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    45455b3 View commit details
    Browse the repository at this point in the history

  32. return unchanged ltype in nullabl;e type utils

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    59de66a View commit details
    Browse the repository at this point in the history

  33. add back ts imputer incompatibility test

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    78c4543 View commit details
    Browse the repository at this point in the history

  34. use dict get return value

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    83a8ac7 View commit details
    Browse the repository at this point in the history

  35. call handle nullable types in oversampler and check schema equality

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    6a10435 View commit details
    Browse the repository at this point in the history

  36. Update tests

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    907e8fe View commit details
    Browse the repository at this point in the history

  37. remove unnecessary comments

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    f42c2b3 View commit details
    Browse the repository at this point in the history

  38. resolve remaining comments

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b6b214e View commit details
    Browse the repository at this point in the history

  39. Copy X in testing nullable types to stop hiding potential incompatibi… 

    …lities in methods
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    6f905c0 View commit details
    Browse the repository at this point in the history

  40. Handle new oversampler nullable type incompatibility and add tests

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    8f4537e View commit details
    Browse the repository at this point in the history

  41. Remove existing nullable type handling from oversampler and use _hand… 

    …le_nullable_types instead
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e4821b5 View commit details
    Browse the repository at this point in the history

  42. Add comments to self

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    be7e744 View commit details
    Browse the repository at this point in the history

  43. Add handle call for lgbm classifier

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    235bcd5 View commit details
    Browse the repository at this point in the history

  44. lint fix

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    1d59441 View commit details
    Browse the repository at this point in the history

  45. Only call handle_nullable_types when necessary in methods

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e01e2bf View commit details
    Browse the repository at this point in the history

  46. Remove remaining unnecessary handle calls

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    762d320 View commit details
    Browse the repository at this point in the history

  47. resolve remaining comments

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    a893157 View commit details
    Browse the repository at this point in the history

  48. Copy X in testing nullable types to stop hiding potential incompatibi… 

    …lities in methods
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    76de2dc View commit details
    Browse the repository at this point in the history

  49. remove nullable type handling after sklearn upgrade fixed incompatibi… 

    …lities
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    5c71449 View commit details
    Browse the repository at this point in the history

  50. Remove downcast call from imputer.py and fix tests

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    401ac62 View commit details
    Browse the repository at this point in the history

  51. remove downcast call from catboost regressor

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    45b8097 View commit details
    Browse the repository at this point in the history

  52. stop adding ohe if bool null present

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    c8f97f0 View commit details
    Browse the repository at this point in the history

  53. remove nullable type handling from knn imputer

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    5819a08 View commit details
    Browse the repository at this point in the history

  54. remove nullable type handling from targer imputer

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    30a8668 View commit details
    Browse the repository at this point in the history

  55. use util for ltype deciding in simple imputer

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    542d37e View commit details
    Browse the repository at this point in the history

  56. Fix broken target imputer test

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    cf5c258 View commit details
    Browse the repository at this point in the history

  57. Remove replace nullable types transformer from automl search and fix … 

    …tests
    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    eedcd0d View commit details
    Browse the repository at this point in the history

  58. Handle nullable types in lgbm classifier predict_proba

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    78fea6a View commit details
    Browse the repository at this point in the history

  59. fix after rebase

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    f845086 View commit details
    Browse the repository at this point in the history

  60. move util to imputer utils and other fixes

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    f3906a2 View commit details
    Browse the repository at this point in the history

  61. remove duplicate util

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    1a8513d View commit details
    Browse the repository at this point in the history

  62. Change how imputer reinits woodwork types

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    358d237 View commit details
    Browse the repository at this point in the history

  63. Expand tests

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    1815e97 View commit details
    Browse the repository at this point in the history

  64. use automl test env

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    bcf31db View commit details
    Browse the repository at this point in the history

  65. fix broken test

    Tamar Grey committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    274f114 View commit details
    Browse the repository at this point in the history