-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update circleci to run checkin tests on py3.8 #462
Conversation
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 98.25% 98.26% +0.01%
==========================================
Files 104 104
Lines 3265 3292 +27
==========================================
+ Hits 3208 3235 +27
Misses 57 57
Continue to review full report at Codecov.
|
Wow, no checkin test errors! And no lint errors, which isn't what I expected. I guess we support python 3.8 now :) |
@@ -161,7 +161,7 @@ jobs: | |||
build_docs: | |||
working_directory: ~/evalml/ | |||
docker: | |||
- image: circleci/python:3.7 | |||
- image: circleci/python:3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary but felt right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, no errors? Sounds good true to be true (though I wonder what happened to that linting issue from a while ago...). 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
@angela97lin yeah I know, I was surprised too! The linting issue may have had something to do with the isort version I had. I can't remember now. Was it just me who had the issue or did you have it too? |
I'm still locally using 3.7.6 but when I tried 3.8.1 I had run into the same issues you did. :o |
Support python 3.8
Fix #310
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request by adding :pr:123
.