Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circleci to run checkin tests on py3.8 #462

merged 2 commits into from Mar 9, 2020


Copy link

@dsherry dsherry commented Mar 7, 2020

Support python 3.8

Fix #310

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request by adding :pr:123.

Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #462 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
+ Coverage   98.25%   98.26%   +0.01%     
  Files         104      104              
  Lines        3265     3292      +27     
+ Hits         3208     3235      +27     
  Misses         57       57
Impacted Files Coverage Δ
...onents/estimators/regressors/ 100% <0%> (ø) ⬆️
...ents/estimators/classifiers/ 100% <0%> (ø) ⬆️
evalml/tests/component_tests/ 100% <0%> (ø) ⬆️
evalml/tests/tuner_tests/ 100% <0%> (ø) ⬆️
evalml/tests/pipeline_tests/ 100% <0%> (ø) ⬆️
...ents/estimators/classifiers/ 100% <0%> (ø) ⬆️
...mponents/estimators/regressors/ 100% <0%> (ø) ⬆️
...s/components/estimators/regressors/ 100% <0%> (ø) ⬆️
.../tests/automl_tests/ 100% <0%> (ø) ⬆️
...nents/estimators/classifiers/ 100% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d62ec...ed9364c. Read the comment docs.

@dsherry dsherry changed the title [WIP] Update circleci to run checkin tests on py3.8 Update circleci to run checkin tests on py3.8 Mar 7, 2020
Copy link
Collaborator Author

dsherry commented Mar 7, 2020

Wow, no checkin test errors! And no lint errors, which isn't what I expected. I guess we support python 3.8 now :)

@@ -161,7 +161,7 @@ jobs:
working_directory: ~/evalml/
- image: circleci/python:3.7
- image: circleci/python:3.8
Copy link
Collaborator Author

@dsherry dsherry Mar 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary but felt right

Copy link

@angela97lin angela97lin left a comment

Wow, no errors? Sounds good true to be true (though I wonder what happened to that linting issue from a while ago...). 🚢

@dsherry dsherry self-assigned this Mar 7, 2020
Copy link

@jeremyliweishih jeremyliweishih left a comment


kmax12 approved these changes Mar 9, 2020
Copy link
Collaborator Author

dsherry commented Mar 9, 2020

@angela97lin yeah I know, I was surprised too! The linting issue may have had something to do with the isort version I had. I can't remember now. Was it just me who had the issue or did you have it too?

@dsherry dsherry merged commit d01cbeb into master Mar 9, 2020
2 checks passed
@dsherry dsherry deleted the ds_310_support_py38 branch Mar 9, 2020
Copy link

angela97lin commented Mar 9, 2020

I'm still locally using 3.7.6 but when I tried 3.8.1 I had run into the same issues you did. :o

@angela97lin angela97lin mentioned this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Support python 3.8
4 participants